In components/autofill, move common/ to core/common/

In components/autofill, move common/ to core/common/

This change is part of moving autofill into its eventual structure of a layered
component. autofill/components/core/ is a new directory that will hold code
that is shared by all platforms (including iOS). This CL moves autofill/
components/common/ underneath this directory; a follow-up CL will move
autofill/components/browser underneath this directory as well.

This CL additionally imposes the correct DEPS restrictions on
autofill/components/core/, with temporary allowances for the current
violating includes.

TBR=joi, thakis, benm
BUG=247015
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206994

[blundell, 2013-06-18 12:31:47]

This is basicall the same CL as https://codereview.chromium.org/17084005/, which
got reverted due to breaking the win_split bot. The only differences are the
following:

- Made the new location components/autofill/core/common rather than
components/autofill/shared after discussion with Jói.
- Modified build/split_link_partition.py to hopefully avoid breaking the
win_slpit builder again

[commit-bot: I haz the power, 2013-06-18 12:32:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/blundell@chromium.org/16879006/1

[commit-bot: I haz the power, 2013-06-18 12:33:16]

Failed to apply patch for chrome/browser/DEPS:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/DEPS
  Hunk #1 FAILED at 6.
  1 out of 1 hunk FAILED -- saving rejects to file chrome/browser/DEPS.rej

Patch:       chrome/browser/DEPS
Index: chrome/browser/DEPS
diff --git a/chrome/browser/DEPS b/chrome/browser/DEPS
index
8980d494b12748fca7c694dd8147c4cb26755478..e8afd51be8de14f13c58ce56aab4f3fa7dfc129d
100644
--- a/chrome/browser/DEPS
+++ b/chrome/browser/DEPS
@@ -6,10 +6,9 @@ include_rules = [
   "+chrome/tools/profiles",  # For history unit tests.
   "+chromeos",
   "+components/autofill/browser",
-  "+components/autofill/common",
   "+components/autofill/content/browser",
+  "+components/autofill/core/common",
   "+components/auto_login_parser",
-  "+components/autofill/common",
   "+components/browser_context_keyed_service",
   "+components/navigation_interception",
   "+components/user_prefs",

[Jói, 2013-06-18 12:41:18]

LGTM

[benm (inactive), 2013-06-18 12:52:22]

aw lgtm

[commit-bot: I haz the power, 2013-06-18 13:09:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/blundell@chromium.org/16879006/11001

[commit-bot: I haz the power, 2013-06-18 14:52:17]

Change committed as 206994

[(unused - use chromium), 2013-06-18 16:50:43]

On Tue, Jun 18, 2013 at 5:31 AM, <blundell@chromium.org> wrote:

> Reviewers: benm, joi, thakis,
>
> Message:
> This is basicall the same CL as https://codereview.chromium.**
> org/17084005/ <https://codereview.chromium.org/17084005/>, which
> got reverted due to breaking the win_split bot. The only differences are
> the
> following:
>

(a good approach is to upload the original change as patch set 1, and the
updated change as patch set 2. then you can say "compare patch set 1 and 2
to see what changed")


>
> - Made the new location components/autofill/core/**common rather than
> components/autofill/shared after discussion with Jói.
> - Modified build/split_link_partition.py to hopefully avoid breaking the
> win_slpit builder again
>
> Description:
> In components/autofill, move common/ to core/common/
>
> This change is part of moving autofill into its eventual structure of a
> layered
> component. autofill/components/core/ is a new directory that will hold code
> that is shared by all platforms (including iOS). This CL moves autofill/
> components/common/ underneath this directory; a follow-up CL will move
> autofill/components/browser underneath this directory as well.
>
> This CL additionally imposes the correct DEPS restrictions on
> autofill/components/core/, with temporary allowances for the current
> violating includes.
>
> TBR=joi, thakis, benm
> BUG=247015
>
> Please review this at
https://codereview.chromium.**org/16879006/<https://codereview.chromium.org/1...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   M android_webview/browser/DEPS
>   M android_webview/browser/aw_**autofill_manager_delegate.cc
>   M android_webview/browser/aw_**form_database_service_**unittest.cc
>   M build/split_link_partition.py
>   M chrome/browser/DEPS
>   M chrome/browser/autofill/**autofill_cc_infobar_delegate.**cc
>   M chrome/browser/password_**manager/password_form_manager.**cc
>   M chrome/browser/password_**manager/password_generation_**manager.cc
>   M chrome/browser/password_**manager/password_manager.h
>   M chrome/browser/password_**manager/password_manager.cc
>   M chrome/browser/password_**manager/password_manager_**delegate_impl.cc
>   M chrome/browser/sync/test/**integration/autofill_helper.cc
>   M chrome/browser/ui/autofill/**autofill_dialog_controller_**
> browsertest.cc
>   M chrome/browser/ui/autofill/**autofill_dialog_controller_**impl.cc
>   M chrome/browser/ui/autofill/**autofill_dialog_controller_**unittest.cc
>   M chrome/browser/ui/cocoa/**autofill/autofill_dialog_**
> cocoa_browsertest.mm <http://autofill_dialog_cocoa_browsertest.mm>
>   M chrome/browser/ui/cocoa/**browser/password_generation_**
> bubble_controller.h
>   M chrome/browser/ui/cocoa/**browser/password_generation_**
> bubble_controller.mm <http://password_generation_bubble_controller.mm>
>   M chrome/browser/ui/gtk/**password_generation_bubble_**gtk.h
>   M chrome/browser/ui/gtk/**password_generation_bubble_**gtk.cc
>   M chrome/browser/ui/views/**password_generation_bubble_**view.h
>   M chrome/browser/ui/views/**password_generation_bubble_**view.cc
>   M chrome/browser/ui/webui/**options/autofill_options_**handler.cc
>   M chrome/chrome_common.gypi
>   M chrome/common/DEPS
>   M chrome/common/chrome_switches.**h
>   M chrome/common/pref_names.h
>   M chrome/renderer/DEPS
>   M chrome/renderer/autofill/**autofill_renderer_browsertest.**cc
>   M chrome/renderer/autofill/form_**autocomplete_browsertest.cc
>   M chrome/renderer/autofill/form_**autofill_browsertest.cc
>   M chrome/renderer/autofill/**password_autofill_agent_**browsertest.cc
>   M chrome/renderer/autofill/**password_generation_manager_**
> browsertest.cc
>   M components/autofill.gypi
>   M components/autofill/DEPS
>   M components/autofill/README
>   M components/autofill/browser/**DEPS
>   M components/autofill/browser/**address_field_unittest.cc
>   M components/autofill/browser/**autocomplete_history_manager.**cc
>   M components/autofill/browser/**autocomplete_history_manager_**
> unittest.cc
>   M components/autofill/browser/**autofill_common_test.cc
>   M components/autofill/browser/**autofill_data_model.cc
>   M components/autofill/browser/**autofill_download.cc
>   M components/autofill/browser/**autofill_download_unittest.cc
>   M components/autofill/browser/**autofill_download_url.cc
>   M components/autofill/browser/**autofill_external_delegate.h
>   M components/autofill/browser/**autofill_external_delegate.cc
>   M components/autofill/browser/**autofill_external_delegate_**unittest.cc
>   M components/autofill/browser/**autofill_field.h
>   M components/autofill/browser/**autofill_manager.h
>   M components/autofill/browser/**autofill_manager.cc
>   M components/autofill/browser/**autofill_manager_unittest.cc
>   M components/autofill/browser/**autofill_merge_unittest.cc
>   M components/autofill/browser/**autofill_metrics.cc
>   M components/autofill/browser/**autofill_metrics_unittest.cc
>   M components/autofill/browser/**autofill_profile.cc
>   M components/autofill/browser/**autofill_profile_unittest.cc
>   M components/autofill/browser/**credit_card.cc
>   M components/autofill/browser/**credit_card_field_unittest.cc
>   M components/autofill/browser/**credit_card_unittest.cc
>   M components/autofill/browser/**form_structure.h
>   M components/autofill/browser/**form_structure.cc
>   M components/autofill/browser/**form_structure_unittest.cc
>   M components/autofill/browser/**name_field_unittest.cc
>   M components/autofill/browser/**password_autofill_manager.h
>   M components/autofill/browser/**password_autofill_manager.cc
>   M components/autofill/browser/**personal_data_manager.cc
>   M components/autofill/browser/**personal_data_manager_**unittest.cc
>   M components/autofill/browser/**phone_field_unittest.cc
>   M components/autofill/browser/**webdata/autofill_table.cc
>   M components/autofill/browser/**webdata/autofill_table_**unittest.cc
>   M components/autofill/browser/**webdata/autofill_webdata_**
> backend_impl.h
>   M components/autofill/browser/**webdata/autofill_webdata_**
> backend_impl.cc
>   M components/autofill/browser/**webdata/autofill_webdata_**service.h
>   M components/autofill/browser/**webdata/autofill_webdata_**service.cc
>   M components/autofill/browser/**webdata/web_data_service_**unittest.cc
>   D components/autofill/common/**OWNERS
>   D components/autofill/common/**autocheckout_status.h
>   D components/autofill/common/**autofill_constants.h
>   D components/autofill/common/**autofill_constants.cc
>   D components/autofill/common/**autofill_message_generator.h
>   D components/autofill/common/**autofill_message_generator.cc
>   D components/autofill/common/**autofill_messages.h
>   D components/autofill/common/**autofill_pref_names.h
>   D components/autofill/common/**autofill_pref_names.cc
>   D components/autofill/common/**autofill_switches.h
>   D components/autofill/common/**autofill_switches.cc
>   D components/autofill/common/**form_data.h
>   D components/autofill/common/**form_data.cc
>   D components/autofill/common/**form_data_predictions.h
>   D components/autofill/common/**form_data_predictions.cc
>   D components/autofill/common/**form_field_data.h
>   D components/autofill/common/**form_field_data.cc
>   D components/autofill/common/**form_field_data_predictions.h
>   D components/autofill/common/**form_field_data_predictions.cc
>   D components/autofill/common/**forms_seen_state.h
>   D components/autofill/common/**password_form_fill_data.h
>   D components/autofill/common/**password_form_fill_data.cc
>   D components/autofill/common/**password_generation_util.h
>   D components/autofill/common/**password_generation_util.cc
>   D components/autofill/common/**web_element_descriptor.h
>   D components/autofill/common/**web_element_descriptor.cc
>   A + components/autofill/content/**DEPS
>   M components/autofill/content/**browser/autocheckout/**
> whitelist_manager.cc
>   M components/autofill/content/**browser/autocheckout/**
> whitelist_manager_unittest.cc
>   M components/autofill/content/**browser/autocheckout_manager.h
>   M components/autofill/content/**browser/autocheckout_manager.**cc
>   M components/autofill/content/**browser/autocheckout_manager_**
> unittest.cc
>   M components/autofill/content/**browser/autocheckout_page_**meta_data.h
>   M components/autofill/content/**browser/autocheckout_request_**manager.h
>   M components/autofill/content/**browser/wallet/wallet_client.h
>   M components/autofill/content/**browser/wallet/wallet_client_**
> unittest.cc
>   M components/autofill/content/**browser/wallet/wallet_service_**url.cc
>   M components/autofill/content/**browser/wallet/wallet_service_**
> url_unittest.cc
>   M components/autofill/content/**renderer/autofill_agent.h
>   M components/autofill/content/**renderer/autofill_agent.cc
>   M components/autofill/content/**renderer/form_autofill_util.h
>   M components/autofill/content/**renderer/form_autofill_util.cc
>   M components/autofill/content/**renderer/form_cache.cc
>   M components/autofill/content/**renderer/password_autofill_**agent.h
>   M components/autofill/content/**renderer/password_autofill_**agent.cc
>   M components/autofill/content/**renderer/password_generation_**
> manager.cc
>   A components/autofill/core/DEPS
>   A + components/autofill/core/**common/OWNERS
>   A + components/autofill/core/**common/autocheckout_status.h
>   A + components/autofill/core/**common/autofill_constants.h
>   A + components/autofill/core/**common/autofill_constants.cc
>   A + components/autofill/core/**common/autofill_message_**generator.h
>   A + components/autofill/core/**common/autofill_message_**generator.cc
>   A + components/autofill/core/**common/autofill_messages.h
>   A + components/autofill/core/**common/autofill_pref_names.h
>   A + components/autofill/core/**common/autofill_pref_names.cc
>   A + components/autofill/core/**common/autofill_switches.h
>   A + components/autofill/core/**common/autofill_switches.cc
>   A + components/autofill/core/**common/form_data.h
>   A + components/autofill/core/**common/form_data.cc
>   A + components/autofill/core/**common/form_data_predictions.h
>   A + components/autofill/core/**common/form_data_predictions.**cc
>   A + components/autofill/core/**common/form_field_data.h
>   A + components/autofill/core/**common/form_field_data.cc
>   A + components/autofill/core/**common/form_field_data_**predictions.h
>   A + components/autofill/core/**common/form_field_data_**predictions.cc
>   A + components/autofill/core/**common/forms_seen_state.h
>   A + components/autofill/core/**common/password_form_fill_**data.h
>   A + components/autofill/core/**common/password_form_fill_**data.cc
>   A + components/autofill/core/**common/password_generation_**util.h
>   A + components/autofill/core/**common/password_generation_**util.cc
>   A + components/autofill/core/**common/web_element_descriptor.**h
>   A + components/autofill/core/**common/web_element_descriptor.**cc
>
>
>