Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Unified Diff: components/autofill/common/password_generation_util.h

Issue 16879006: In components/autofill, move common/ to core/common/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase to fix conflict Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/common/password_generation_util.h
diff --git a/components/autofill/common/password_generation_util.h b/components/autofill/common/password_generation_util.h
deleted file mode 100644
index a855958d5325811f4d1bc7f4d82b025b3998624b..0000000000000000000000000000000000000000
--- a/components/autofill/common/password_generation_util.h
+++ /dev/null
@@ -1,77 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef COMPONENTS_AUTOFILL_COMMON_PASSWORD_GENERATION_UTIL_H_
-#define COMPONENTS_AUTOFILL_COMMON_PASSWORD_GENERATION_UTIL_H_
-
-namespace autofill {
-namespace password_generation {
-
-// Enumerates various events related to the password generation process.
-enum PasswordGenerationEvent {
- // No Account creation form is detected.
- NO_SIGN_UP_DETECTED,
-
- // Account creation form is detected.
- SIGN_UP_DETECTED,
-
- // Password generation icon is shown inside the first password field.
- ICON_SHOWN,
-
- // Password generation bubble is shown after user clicks on the icon.
- BUBBLE_SHOWN,
-
- // Number of enum entries, used for UMA histogram reporting macros.
- EVENT_ENUM_COUNT
-};
-
-// Wrapper to store the user interactions with the password generation bubble.
-struct PasswordGenerationActions {
- // Whether the user has clicked on the learn more link.
- bool learn_more_visited;
-
- // Whether the user has accepted the generated password.
- bool password_accepted;
-
- // Whether the user has manually edited password entry.
- bool password_edited;
-
- // Whether the user has clicked on the regenerate button.
- bool password_regenerated;
-
- PasswordGenerationActions();
- ~PasswordGenerationActions();
-};
-
-void LogUserActions(PasswordGenerationActions actions);
-
-void LogPasswordGenerationEvent(PasswordGenerationEvent event);
-
-// Enumerates user actions after password generation bubble is shown.
-// These are visible for testing purposes.
-enum UserAction {
- // User closes the bubble without any meaningful actions (e.g. use backspace
- // key, close the bubble, click outside the bubble, etc).
- IGNORE_FEATURE,
-
- // User navigates to the learn more page. Note that in the current
- // implementation this will result in closing the bubble so this action
- // doesn't overlap with the following two actions.
- LEARN_MORE,
-
- // User accepts the generated password without manually editing it (but
- // including changing it through the regenerate button).
- ACCEPT_ORIGINAL_PASSWORD,
-
- // User accepts the gererated password after manually editing it.
- ACCEPT_AFTER_EDITING,
-
- // Number of enum entries, used for UMA histogram reporting macros.
- ACTION_ENUM_COUNT
-};
-
-} // namespace password_generation
-} // namespace autofill
-
-#endif // COMPONENTS_AUTOFILL_COMMON_PASSWORD_GENERATION_UTIL_H_
« no previous file with comments | « components/autofill/common/password_form_fill_data.cc ('k') | components/autofill/common/password_generation_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698