Issue 16871004: add SkIntToScalar and SkFloatToScalar to stop build errors on Mac10.6

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16871004: add SkIntToScalar and SkFloatToScalar to stop build errors on Mac10.6 (Closed)

Created:
7 years, 6 months ago by ducky

Modified:
7 years, 6 months ago

Reviewers:
vandebo (ex-Chrome)

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

add SkIntToScalar and SkFloatToScalar to stop build errors on Mac10.6 BUG= Committed: http://code.google.com/p/skia/source/detail?r=9562

Patch Set 2 : Replace wall of Sk*ToScalar with const variable defines #

Patch Set 3 : Let's try that again... #

Total comments: 1

Patch Set 4 : Use ALL the SkIntToScalar! #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -24 lines)			Patch
	M	gm/gradient_matrix.cpp	View	1 2 3	2 chunks	+32 lines, -24 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

vandebo (ex-Chrome)

LGTM after comment. https://chromiumcodereview.appspot.com/16871004/diff/7001/gm/gradient_matrix.cpp File gm/gradient_matrix.cpp (right): https://chromiumcodereview.appspot.com/16871004/diff/7001/gm/gradient_matrix.cpp#newcode59 gm/gradient_matrix.cpp:59: static const SkScalar TESTGRID_X = 200; ...

7 years, 6 months ago (2013-06-12 23:16:41 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/richardlin@chromium.org/16871004/11001

7 years, 6 months ago (2013-06-12 23:20:37 UTC) #5

Message was sent while issue was closed.

Change committed as 9562