Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1686223002: Move InterfaceProvider into the shell::mojom namespace like the rest of the shell interfaces. (Closed)

Created:
4 years, 10 months ago by Ben Goodger (Google)
Modified:
4 years, 10 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, nasko+codewatch_chromium.org, yzshen+watch_chromium.org, kinuko+watch, ben+mojo_chromium.org, jsbell+serviceworker_chromium.org, tzik, jam, abarth-chromium, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, blink-worker-reviews_chromium.org, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, extensions-reviews_chromium.org, Peter Beverloo, nhiroki, feature-media-reviews_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org, michaeln, serviceworker-reviews, Aaron Boodman, kinuko+serviceworker, mkwst+moarreviews-renderer_chromium.org, horo+watch_chromium.org, darin (slow to review)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move InterfaceProvider into the shell::mojom namespace like the rest of the shell interfaces. TBR=rockot@chromium.org R=palmer@chromium.org BUG= CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/80ab890512a739dc43bf4a2c6494c9d766b62106 Cr-Commit-Position: refs/heads/master@{#374968}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+181 lines, -160 lines) Patch
M content/browser/frame_host/frame_mojo_shell.h View 1 2 chunks +4 lines, -3 lines 0 comments Download
M content/browser/frame_host/frame_mojo_shell.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/mojo/mojo_app_connection_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/mojo/mojo_app_connection_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/mojo/mojo_application_host.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/mojo/mojo_shell_context.h View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/mojo/mojo_shell_context.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M content/browser/service_worker/embedded_worker_instance.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download
M content/browser/service_worker/embedded_worker_test_helper.h View 1 chunk +4 lines, -3 lines 0 comments Download
M content/browser/service_worker/embedded_worker_test_helper.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M content/child/mojo/mojo_application.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/application_setup.mojom View 1 1 chunk +3 lines, -2 lines 0 comments Download
M content/common/mojo/service_registry_impl.h View 1 3 chunks +6 lines, -5 lines 0 comments Download
M content/common/mojo/service_registry_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/render_frame_setup.mojom View 1 chunk +4 lines, -3 lines 0 comments Download
M content/common/service_worker/embedded_worker_setup.mojom View 1 chunk +4 lines, -3 lines 0 comments Download
M content/renderer/render_frame_impl.h View 2 chunks +4 lines, -3 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M content/renderer/render_thread_impl.h View 3 chunks +10 lines, -8 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 6 chunks +12 lines, -12 lines 0 comments Download
M content/renderer/service_worker/service_worker_context_client.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/service_worker/service_worker_context_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/browser/shell_mojo_test_utils_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/mojo/stash_backend_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/services/android_mojo_media_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/mojo/services/default_mojo_media_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/services/mojo_media_client.h View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M media/mojo/services/mojo_media_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/services/service_factory_impl.h View 1 2 3 chunks +6 lines, -2 lines 0 comments Download
M media/mojo/services/service_factory_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/application_instance.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/shell/application_instance.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/shell/capability_filter_test.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M mojo/shell/connect_to_application_params.h View 2 chunks +6 lines, -6 lines 0 comments Download
M mojo/shell/connect_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/fetcher/about_fetcher_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/shell/package_manager/content_handler_connection.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/public/cpp/connect.h View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/public/cpp/connection.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/shell/public/cpp/lib/application_test_base.cc View 1 chunk +7 lines, -6 lines 0 comments Download
M mojo/shell/public/cpp/lib/connection_impl.h View 4 chunks +8 lines, -7 lines 0 comments Download
M mojo/shell/public/cpp/lib/connection_impl.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M mojo/shell/public/cpp/lib/shell_connection.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M mojo/shell/public/cpp/shell_connection.h View 1 2 1 chunk +7 lines, -6 lines 0 comments Download
M mojo/shell/public/interfaces/interface_provider.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/public/interfaces/shell.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/shell/public/interfaces/shell_client.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/shell/standalone/context.cc View 4 chunks +8 lines, -7 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 18 (8 generated)
Ben Goodger (Google)
mechanical rename into a nested namespace. palmer: content mojoms. rockot: all
4 years, 10 months ago (2016-02-10 21:46:34 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1686223002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1686223002/20001
4 years, 10 months ago (2016-02-10 21:46:52 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/179422)
4 years, 10 months ago (2016-02-10 22:29:09 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1686223002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1686223002/40001
4 years, 10 months ago (2016-02-11 06:26:37 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-11 10:21:04 UTC) #10
Ben Goodger (Google)
On 2016/02/11 10:21:04, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 10 months ago (2016-02-11 18:04:32 UTC) #12
palmer
lgtm
4 years, 10 months ago (2016-02-11 19:10:34 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1686223002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1686223002/40001
4 years, 10 months ago (2016-02-11 20:10:13 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-11 20:19:42 UTC) #16
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:37:30 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/80ab890512a739dc43bf4a2c6494c9d766b62106
Cr-Commit-Position: refs/heads/master@{#374968}

Powered by Google App Engine
This is Rietveld 408576698