Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 16845005: Don't use a sleep in the browser's main thread to throttle swapbuffers. (Closed)

Created:
7 years, 6 months ago by ccameron
Modified:
7 years, 6 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, sail+watch_chromium.org, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su
Visibility:
Public.

Description

Don't use a sleep in the browser's main thread to throttle swapbuffers. Throttle by delaying sending the ack of each frame to the renderer until a vsync interval has passed since the last ack was sent. Explicitly disable throttling when threaded compositing is enabled (it was supposed to not kick in because the thread proxy will not send new frames more than once per vsync). Also move informing the renderer of the vsync properties to be immediate (not delayed with the ack) and only send this data when a new frame has been sent (not every time all acks are cleared). This should not have any material impact, and is to make the flow easier to follow. BUG=245900 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206338

Patch Set 1 #

Patch Set 2 : Clean up diffs #

Patch Set 3 : Add more comments #

Patch Set 4 : Resolve against head #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -69 lines) Patch
M content/browser/renderer_host/compositing_iosurface_layer_mac.mm View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/compositing_iosurface_mac.mm View 4 chunks +0 lines, -36 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 1 2 3 3 chunks +16 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 2 3 5 chunks +71 lines, -32 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
ccameron
This re-visits the change in https://chromiumcodereview.appspot.com/10828104 I plan to remove the vsync info from CompositingIOSurface ...
7 years, 6 months ago (2013-06-12 22:38:23 UTC) #1
Ken Russell (switch to Gerrit)
LGTM -- this seems like a very good change.
7 years, 6 months ago (2013-06-12 23:10:47 UTC) #2
ccameron
Thanks!!
7 years, 6 months ago (2013-06-12 23:33:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/16845005/9001
7 years, 6 months ago (2013-06-14 01:48:56 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 6 months ago (2013-06-14 02:11:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/16845005/9001
7 years, 6 months ago (2013-06-14 04:01:12 UTC) #6
commit-bot: I haz the power
7 years, 6 months ago (2013-06-14 06:47:33 UTC) #7
Message was sent while issue was closed.
Change committed as 206338

Powered by Google App Engine
This is Rietveld 408576698