Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 16841013: Have the ui_test_support target be of type none on iOS. (Closed)

Created:
7 years, 6 months ago by blundell
Modified:
7 years, 6 months ago
CC:
chromium-reviews, stuartmorgan
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Have the ui_test_support target be of type none on iOS. After https://chromiumcodereview.appspot.com/16024014, the ui_test_support target has no sources that are built on iOS. This causes targets that depend on this target to fail linkage because the ui_test_support library can't be found. R=thakis Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206147

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M ui/ui_unittests.gypi View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
blundell
I assume that the reason that this hasn't caused bot failures (yet) is that they ...
7 years, 6 months ago (2013-06-13 12:45:41 UTC) #1
Nico
lgtm Another possible fix would be to have a dummy source file in this target ...
7 years, 6 months ago (2013-06-13 15:48:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/16841013/1
7 years, 6 months ago (2013-06-13 16:28:38 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-06-13 20:00:13 UTC) #4
Message was sent while issue was closed.
Change committed as 206147

Powered by Google App Engine
This is Rietveld 408576698