Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 16024014: Move DummyInputMethod into ui/base/ime/ (Closed)

Created:
7 years, 6 months ago by Yohei Yukawa
Modified:
7 years, 6 months ago
Reviewers:
Seigo Nonaka, yukawa, sky
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, ben+watch_chromium.org, penghuang+watch_chromium.org, nona+watch_chromium.org, James Su, kochi, Yuki, yoichio
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Move DummyInputMethod into ui/base/ime/ This patch set moves dummy_input_method.h/cc into ui/base/ime/ so that refactoring of IME interface can be done more easily. BUG=246534 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205763

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -143 lines) Patch
M ui/aura/test/aura_test_helper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + ui/base/ime/dummy_input_method.h View 3 chunks +3 lines, -6 lines 0 comments Download
A + ui/base/ime/dummy_input_method.cc View 2 chunks +1 line, -3 lines 0 comments Download
M ui/base/ime/ime_test_support.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
D ui/base/test/dummy_input_method.h View 1 chunk +0 lines, -50 lines 0 comments Download
D ui/base/test/dummy_input_method.cc View 1 chunk +0 lines, -80 lines 0 comments Download
M ui/ui_unittests.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Yohei Yukawa
7 years, 6 months ago (2013-06-11 02:37:53 UTC) #1
Seigo Nonaka
lgtm
7 years, 6 months ago (2013-06-11 03:30:54 UTC) #2
Yohei Yukawa
+sky@ for the owner review. Could you take a look? Thanks,
7 years, 6 months ago (2013-06-11 03:41:25 UTC) #3
sky
LGTM
7 years, 6 months ago (2013-06-11 16:17:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Yukawa@chromium.org/16024014/2001
7 years, 6 months ago (2013-06-12 00:58:54 UTC) #5
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 6 months ago (2013-06-12 03:01:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Yukawa@chromium.org/16024014/2001
7 years, 6 months ago (2013-06-12 03:37:17 UTC) #7
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
7 years, 6 months ago (2013-06-12 13:41:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Yukawa@chromium.org/16024014/2001
7 years, 6 months ago (2013-06-12 13:48:41 UTC) #9
commit-bot: I haz the power
7 years, 6 months ago (2013-06-12 13:50:47 UTC) #10
Message was sent while issue was closed. 
Change committed as 205763

Powered by Google App Engine
This is Rietveld 408576698