Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1682843003: Add additive animation support for border-radius CSS properties (Closed)

Created:
4 years, 10 months ago by alancutter (OOO until 2018)
Modified:
4 years, 10 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@_positionInterpolation
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add additive animation support for border-radius CSS properties This patch adds support for composite modes on border-radius CSS animations via element.animate(). BUG=437696 Committed: https://crrev.com/bd831cabec2a2d24c0b635995df4677cb4b8f46d Cr-Commit-Position: refs/heads/master@{#376159} Committed: https://crrev.com/c0106b85472130a7ef9c1c452da53dbecf0b9fb0 Cr-Commit-Position: refs/heads/master@{#377742}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review changes #

Patch Set 3 : Rebased #

Patch Set 4 : Rebased #

Patch Set 5 : Rebased #

Messages

Total messages: 34 (15 generated)
alancutter (OOO until 2018)
4 years, 10 months ago (2016-02-10 07:26:42 UTC) #2
Eric Willigers
lgtm https://codereview.chromium.org/1682843003/diff/1/third_party/WebKit/LayoutTests/animations/composition/border-bottom-left-radius-composition.html File third_party/WebKit/LayoutTests/animations/composition/border-bottom-left-radius-composition.html (right): https://codereview.chromium.org/1682843003/diff/1/third_party/WebKit/LayoutTests/animations/composition/border-bottom-left-radius-composition.html#newcode7 third_party/WebKit/LayoutTests/animations/composition/border-bottom-left-radius-composition.html:7: underlying: '40px 40px', I would like some of ...
4 years, 10 months ago (2016-02-10 09:18:24 UTC) #3
alancutter (OOO until 2018)
https://codereview.chromium.org/1682843003/diff/1/third_party/WebKit/LayoutTests/animations/composition/border-bottom-left-radius-composition.html File third_party/WebKit/LayoutTests/animations/composition/border-bottom-left-radius-composition.html (right): https://codereview.chromium.org/1682843003/diff/1/third_party/WebKit/LayoutTests/animations/composition/border-bottom-left-radius-composition.html#newcode7 third_party/WebKit/LayoutTests/animations/composition/border-bottom-left-radius-composition.html:7: underlying: '40px 40px', On 2016/02/10 at 09:18:24, Eric Willigers ...
4 years, 10 months ago (2016-02-11 00:24:54 UTC) #4
alancutter (OOO until 2018)
+dstockwell for core.gypi changes.
4 years, 10 months ago (2016-02-17 05:46:36 UTC) #6
dstockwell
lgtm
4 years, 10 months ago (2016-02-18 03:00:44 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1682843003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1682843003/40001
4 years, 10 months ago (2016-02-18 04:53:46 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/160332) ios_dbg_simulator_ninja on ...
4 years, 10 months ago (2016-02-18 04:56:37 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1682843003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1682843003/60001
4 years, 10 months ago (2016-02-18 07:13:39 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-18 08:44:21 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1682843003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1682843003/60001
4 years, 10 months ago (2016-02-18 13:23:22 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 10 months ago (2016-02-18 13:30:32 UTC) #19
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/bd831cabec2a2d24c0b635995df4677cb4b8f46d Cr-Commit-Position: refs/heads/master@{#376159}
4 years, 10 months ago (2016-02-18 13:32:45 UTC) #21
Theresa
The patchset this is dependent on is causing compilation to fail on Android arm64, x64 ...
4 years, 10 months ago (2016-02-18 17:09:13 UTC) #23
Theresa
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/1706273002/ by twellington@chromium.org. ...
4 years, 10 months ago (2016-02-18 17:11:13 UTC) #24
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1682843003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1682843003/80001
4 years, 10 months ago (2016-02-25 03:29:46 UTC) #26
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-25 05:54:01 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1682843003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1682843003/80001
4 years, 10 months ago (2016-02-26 00:33:29 UTC) #31
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 10 months ago (2016-02-26 01:02:13 UTC) #32
commit-bot: I haz the power
4 years, 10 months ago (2016-02-26 01:03:41 UTC) #34
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/c0106b85472130a7ef9c1c452da53dbecf0b9fb0
Cr-Commit-Position: refs/heads/master@{#377742}

Powered by Google App Engine
This is Rietveld 408576698