Issue 16820002: [Android] Separate concepts of pushing test data and installing test apk.

Issue 16820002: [Android] Separate concepts of pushing test data and installing test apk. (Closed)

Created:
7 years, 6 months ago by frankf

Modified:
7 years, 6 months ago

Reviewers:
craigdh, nilesh

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Android] Separate concepts of pushing test data and installing test apk. --skip-deps-push will now only bypass the former. BUG= NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206096

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed Nilesh's comments #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -12 lines)			Patch
M	build/android/pylib/base/base_test_runner.py	View	1	1 chunk	+10 lines, -5 lines	0 comments	Download
M	build/android/pylib/gtest/test_runner.py	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	build/android/pylib/host_driven/run_python_tests.py	View	1	1 chunk	+6 lines, -1 line	0 comments	Download
M	build/android/pylib/instrumentation/test_runner.py	View		2 chunks	+6 lines, -3 lines	0 comments	Download
M	build/android/pylib/uiautomator/test_runner.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	build/android/pylib/utils/test_options_parser.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

nilesh

https://codereview.chromium.org/16820002/diff/1/build/android/pylib/base/base_test_runner.py File build/android/pylib/base/base_test_runner.py (right): https://codereview.chromium.org/16820002/diff/1/build/android/pylib/base/base_test_runner.py#newcode100 build/android/pylib/base/base_test_runner.py:100: self.InstallTestPackage() This should be called before PushDataDeps to maintain ...

7 years, 6 months ago (2013-06-12 20:07:45 UTC) #2

frankf

PTAL https://codereview.chromium.org/16820002/diff/1/build/android/pylib/base/base_test_runner.py File build/android/pylib/base/base_test_runner.py (right): https://codereview.chromium.org/16820002/diff/1/build/android/pylib/base/base_test_runner.py#newcode100 build/android/pylib/base/base_test_runner.py:100: self.InstallTestPackage() On 2013/06/12 20:07:45, nilesh wrote: > This ...

7 years, 6 months ago (2013-06-12 20:53:56 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/frankf@chromium.org/16820002/9001

7 years, 6 months ago (2013-06-13 16:53:20 UTC) #6

Message was sent while issue was closed.

Change committed as 206096

Expand Messages | Collapse Messages