Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: build/android/pylib/gtest/test_runner.py

Issue 16820002: [Android] Separate concepts of pushing test data and installing test apk. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed Nilesh's comments Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import glob 5 import glob
6 import logging 6 import logging
7 import os 7 import os
8 8
9 from pylib import android_commands 9 from pylib import android_commands
10 from pylib import constants 10 from pylib import constants
(...skipping 255 matching lines...) Expand 10 before | Expand all | Expand 10 after
266 self.test_package = test_package_executable.TestPackageExecutable( 266 self.test_package = test_package_executable.TestPackageExecutable(
267 self.adb, 267 self.adb,
268 device, 268 device,
269 test_suite, 269 test_suite,
270 timeout, 270 timeout,
271 self._cleanup_test_files, 271 self._cleanup_test_files,
272 self.tool, 272 self.tool,
273 symbols_dir) 273 symbols_dir)
274 274
275 #override 275 #override
276 def PushDependencies(self): 276 def InstallTestPackage(self):
277 self.test_package.StripAndCopyExecutable() 277 self.test_package.StripAndCopyExecutable()
278 self.test_package.PushDataAndPakFiles() 278 self.test_package.PushDataAndPakFiles()
279
280 #override
281 def PushDataDeps(self):
279 self.tool.CopyFiles() 282 self.tool.CopyFiles()
280 test_data = _GetDataFilesForTestSuite(self.test_package.test_suite_basename) 283 test_data = _GetDataFilesForTestSuite(self.test_package.test_suite_basename)
281 if test_data: 284 if test_data:
282 # Make sure SD card is ready. 285 # Make sure SD card is ready.
283 self.adb.WaitForSdCardReady(20) 286 self.adb.WaitForSdCardReady(20)
284 for data in test_data: 287 for data in test_data:
285 self.CopyTestData([data], self.adb.GetExternalStorage()) 288 self.CopyTestData([data], self.adb.GetExternalStorage())
286 optional_test_data = _GetOptionalDataFilesForTestSuite( 289 optional_test_data = _GetOptionalDataFilesForTestSuite(
287 self.test_package.test_suite_basename) 290 self.test_package.test_suite_basename)
288 if optional_test_data: 291 if optional_test_data:
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
364 self.LaunchChromeTestServerSpawner() 367 self.LaunchChromeTestServerSpawner()
365 self.tool.SetupEnvironment() 368 self.tool.SetupEnvironment()
366 369
367 #override 370 #override
368 def TearDown(self): 371 def TearDown(self):
369 """Cleans up the test enviroment for the test suite.""" 372 """Cleans up the test enviroment for the test suite."""
370 self.tool.CleanUpEnvironment() 373 self.tool.CleanUpEnvironment()
371 if self._cleanup_test_files: 374 if self._cleanup_test_files:
372 self.adb.RemovePushedFiles() 375 self.adb.RemovePushedFiles()
373 super(TestRunner, self).TearDown() 376 super(TestRunner, self).TearDown()
OLDNEW
« no previous file with comments | « build/android/pylib/base/base_test_runner.py ('k') | build/android/pylib/host_driven/run_python_tests.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698