Extracts InterfaceRegistry from ConnectionImpl.

Extracts InterfaceRegistry from ConnectionImpl.

For most existing Mojo uses outside of Chrome, we have been relying on Connection::AddService<T>() as the means of exposing interfaces to other applications, because primarily we have been doing this via the InterfaceProviders exchanged @ Shell::ConnectToApplication.

However there have been times in the past and are likely to be again in the future where we will want to pass an InterfaceProvider to another method, so having a canonical implementation of an InterfaceRegistry seems useful.

I pulled all the relevant bits out of ConnectionImpl into this utility and then made ConnectionImpl wrap it. I suspect in time we could replace some of the custom InterfaceProvider impls currently in Content with this.

R=rockot@chromium.org
BUG=

Committed: https://crrev.com/e83e09a1f670d57be60d75453dfa5be32f02d47d
Cr-Commit-Position: refs/heads/master@{#375146}

[Ben Goodger (Google), 2016-02-11 06:20:29]

Description was changed from

==========
InterfaceRegistry

BUG=
==========

to

==========
Extracts InterfaceRegistry from ConnectionImpl.

For most existing Mojo uses outside of Chrome, we have been relying on
Connection::AddService<T>() as the means of exposing interfaces to other
applications, because primarily we have been doing this via the
InterfaceProviders exchanged @ Shell::ConnectToApplication.

However there have been times in the past and are likely to be again in the
future where we will want to pass an InterfaceProvider to another method, so
having a canonical implementation of an InterfaceRegistry seems useful.

I pulled all the relevant bits out of ConnectionImpl into this utility and then
made ConnectionImpl wrap it. I suspect in time we could replace some of the
custom InterfaceProvider impls currently in Content with this.

R=rockot@chromium.org
BUG=
==========

[Ben Goodger (Google), 2016-02-11 06:20:29]

ben@chromium.org changed reviewers:
+ rockot@chromium.org

[Ben Goodger (Google), 2016-02-11 06:26:30]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-11 06:26:36]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1681933005/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1681933005/80001

[commit-bot: I haz the power, 2016-02-11 06:41:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-11 06:41:04]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Ben Goodger (Google), 2016-02-11 20:32:57]

The CQ bit was checked by ben@chromium.org

[commit-bot: I haz the power, 2016-02-11 20:36:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1681933005/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1681933005/100001

[commit-bot: I haz the power, 2016-02-11 20:36:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-11 20:36:31]

No L-G-T-M from a valid reviewer yet. Only full committers are accepted.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Ken Rockot(use gerrit already), 2016-02-11 20:51:50]

lgtm with one question and general comments: will it always be clear what the
lifetime of a connection is, and therefore what the lifetime of a connection's
registry is? it would be not great to have to reason about this vs the lifetime
of various InterfaceFactory<T>s.

in the same vein it would also be nice to have some InterfaceBinder adapters for
base::Callback/std::function, and first-class support for those on
InterfaceRegistry

[Ben Goodger (Google), 2016-02-11 21:37:03]

On 2016/02/11 20:51:50, Ken Rockot wrote:
> lgtm with one question and general comments: will it always be clear what the
> lifetime of a connection is, and therefore what the lifetime of a connection's
> registry is? it would be not great to have to reason about this vs the
lifetime
> of various InterfaceFactory<T>s.

Good question. I thought there was something on this but as it happens it looks
like it's not even implemented. I'll think about this next. Currently the
ShellConnection tracks instances of this object for inbound connections, and
these objects afaict are never destroyed. Without transferring ownership to the
ShellClient it may not be possible to do so without more notification
infrastructure (which probably needs to be built). What I'd probably like to see
is ConnectionImpl track the lifetime of the InterfaceProvider link, and destroy
itself when it dies, notifying dependent ShellClients.

> in the same vein it would also be nice to have some InterfaceBinder adapters
for
> base::Callback/std::function, and first-class support for those on
> InterfaceRegistry

Scott was asking about this too. I think I'll let him add it.

[Ben Goodger (Google), 2016-02-11 21:37:10]

The CQ bit was checked by ben@chromium.org

[commit-bot: I haz the power, 2016-02-11 21:39:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1681933005/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1681933005/100001

[commit-bot: I haz the power, 2016-02-11 21:44:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-11 21:44:36]

Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ben Goodger (Google), 2016-02-11 21:51:35]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-02-11 21:51:36]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/1681933005/#ps120001
(title: ".")

[commit-bot: I haz the power, 2016-02-11 21:53:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1681933005/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1681933005/120001

[Ben Goodger (Google), 2016-02-11 21:54:26]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-02-11 21:54:26]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/1681933005/#ps140001
(title: ".")

[commit-bot: I haz the power, 2016-02-11 21:54:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1681933005/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1681933005/140001

[commit-bot: I haz the power, 2016-02-11 22:09:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-11 22:09:25]

Try jobs failed on following builders:
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Ben Goodger (Google), 2016-02-11 23:42:54]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-02-11 23:42:54]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/1681933005/#ps160001
(title: ".")

[commit-bot: I haz the power, 2016-02-11 23:43:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1681933005/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1681933005/160001

[commit-bot: I haz the power, 2016-02-12 00:17:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-12 00:17:53]

Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ben Goodger (Google), 2016-02-12 04:03:05]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-02-12 04:03:05]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/1681933005/#ps180001
(title: ".")

[commit-bot: I haz the power, 2016-02-12 04:03:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1681933005/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1681933005/180001

[commit-bot: I haz the power, 2016-02-12 04:40:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-12 04:40:53]

Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[Ben Goodger (Google), 2016-02-12 05:09:21]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-02-12 05:09:22]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/1681933005/#ps200001
(title: ".")

[commit-bot: I haz the power, 2016-02-12 05:10:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1681933005/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1681933005/200001

[commit-bot: I haz the power, 2016-02-12 06:21:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-12 06:21:26]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ben Goodger (Google), 2016-02-12 06:39:45]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-02-12 06:39:46]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/1681933005/#ps220001
(title: ".")

[commit-bot: I haz the power, 2016-02-12 06:39:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1681933005/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1681933005/220001

[commit-bot: I haz the power, 2016-02-12 08:26:52]

Description was changed from

==========
Extracts InterfaceRegistry from ConnectionImpl.

For most existing Mojo uses outside of Chrome, we have been relying on
Connection::AddService<T>() as the means of exposing interfaces to other
applications, because primarily we have been doing this via the
InterfaceProviders exchanged @ Shell::ConnectToApplication.

However there have been times in the past and are likely to be again in the
future where we will want to pass an InterfaceProvider to another method, so
having a canonical implementation of an InterfaceRegistry seems useful.

I pulled all the relevant bits out of ConnectionImpl into this utility and then
made ConnectionImpl wrap it. I suspect in time we could replace some of the
custom InterfaceProvider impls currently in Content with this.

R=rockot@chromium.org
BUG=
==========

to

==========
Extracts InterfaceRegistry from ConnectionImpl.

For most existing Mojo uses outside of Chrome, we have been relying on
Connection::AddService<T>() as the means of exposing interfaces to other
applications, because primarily we have been doing this via the
InterfaceProviders exchanged @ Shell::ConnectToApplication.

However there have been times in the past and are likely to be again in the
future where we will want to pass an InterfaceProvider to another method, so
having a canonical implementation of an InterfaceRegistry seems useful.

I pulled all the relevant bits out of ConnectionImpl into this utility and then
made ConnectionImpl wrap it. I suspect in time we could replace some of the
custom InterfaceProvider impls currently in Content with this.

R=rockot@chromium.org
BUG=
==========

[commit-bot: I haz the power, 2016-02-12 08:26:53]

Committed patchset #12 (id:220001)

[commit-bot: I haz the power, 2016-02-16 22:42:18]

Description was changed from

==========
Extracts InterfaceRegistry from ConnectionImpl.

For most existing Mojo uses outside of Chrome, we have been relying on
Connection::AddService<T>() as the means of exposing interfaces to other
applications, because primarily we have been doing this via the
InterfaceProviders exchanged @ Shell::ConnectToApplication.

However there have been times in the past and are likely to be again in the
future where we will want to pass an InterfaceProvider to another method, so
having a canonical implementation of an InterfaceRegistry seems useful.

I pulled all the relevant bits out of ConnectionImpl into this utility and then
made ConnectionImpl wrap it. I suspect in time we could replace some of the
custom InterfaceProvider impls currently in Content with this.

R=rockot@chromium.org
BUG=
==========

to

==========
Extracts InterfaceRegistry from ConnectionImpl.

For most existing Mojo uses outside of Chrome, we have been relying on
Connection::AddService<T>() as the means of exposing interfaces to other
applications, because primarily we have been doing this via the
InterfaceProviders exchanged @ Shell::ConnectToApplication.

However there have been times in the past and are likely to be again in the
future where we will want to pass an InterfaceProvider to another method, so
having a canonical implementation of an InterfaceRegistry seems useful.

I pulled all the relevant bits out of ConnectionImpl into this utility and then
made ConnectionImpl wrap it. I suspect in time we could replace some of the
custom InterfaceProvider impls currently in Content with this.

R=rockot@chromium.org
BUG=

Committed: https://crrev.com/e83e09a1f670d57be60d75453dfa5be32f02d47d
Cr-Commit-Position: refs/heads/master@{#375146}
==========

[commit-bot: I haz the power, 2016-02-16 22:42:19]

Patchset 12 (id:??) landed as
https://crrev.com/e83e09a1f670d57be60d75453dfa5be32f02d47d
Cr-Commit-Position: refs/heads/master@{#375146}