src/ia32/stub-cache-ia32.cc - Issue 16818014: Only extend storage if FIELD

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/stub-cache-ia32.cc

Issue 16818014: Only extend storage if FIELD (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/stub-cache-ia32.cc

diff --git a/src/ia32/stub-cache-ia32.cc b/src/ia32/stub-cache-ia32.cc

index 51c3692e432bfb779d8e63b4e001efe1b4b9847d..f7c570aea82620a3a02b1b4738989aaa69b66ff7 100644

--- a/src/ia32/stub-cache-ia32.cc

+++ b/src/ia32/stub-cache-ia32.cc

@@ -890,7 +890,8 @@ void StubCompiler::GenerateStoreTransition(MacroAssembler* masm,

ASSERT(object->IsJSGlobalProxy() || !object->IsAccessCheckNeeded());

// Perform map transition for the receiver if necessary.

- if (object->map()->unused_property_fields() == 0) {

+ if (details.type() == FIELD &&

+ object->map()->unused_property_fields() == 0) {

// The properties must be extended before we can store the value.

// We jump to a runtime call that extends the properties array.

__ pop(scratch1); // Return address.

« no previous file with comments | « src/arm/stub-cache-arm.cc ('k') | src/x64/stub-cache-x64.cc » ('j') | no next file with comments »