Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Side by Side Diff: src/ia32/stub-cache-ia32.cc

Issue 16818014: Only extend storage if FIELD (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/stub-cache-arm.cc ('k') | src/x64/stub-cache-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 872 matching lines...) Expand 10 before | Expand all | Expand 10 after
883 } else { 883 } else {
884 __ fstp_d(FieldOperand(storage_reg, HeapNumber::kValueOffset)); 884 __ fstp_d(FieldOperand(storage_reg, HeapNumber::kValueOffset));
885 } 885 }
886 } 886 }
887 887
888 // Stub never generated for non-global objects that require access 888 // Stub never generated for non-global objects that require access
889 // checks. 889 // checks.
890 ASSERT(object->IsJSGlobalProxy() || !object->IsAccessCheckNeeded()); 890 ASSERT(object->IsJSGlobalProxy() || !object->IsAccessCheckNeeded());
891 891
892 // Perform map transition for the receiver if necessary. 892 // Perform map transition for the receiver if necessary.
893 if (object->map()->unused_property_fields() == 0) { 893 if (details.type() == FIELD &&
894 object->map()->unused_property_fields() == 0) {
894 // The properties must be extended before we can store the value. 895 // The properties must be extended before we can store the value.
895 // We jump to a runtime call that extends the properties array. 896 // We jump to a runtime call that extends the properties array.
896 __ pop(scratch1); // Return address. 897 __ pop(scratch1); // Return address.
897 __ push(receiver_reg); 898 __ push(receiver_reg);
898 __ push(Immediate(transition)); 899 __ push(Immediate(transition));
899 __ push(value_reg); 900 __ push(value_reg);
900 __ push(scratch1); 901 __ push(scratch1);
901 __ TailCallExternalReference( 902 __ TailCallExternalReference(
902 ExternalReference(IC_Utility(IC::kSharedStoreIC_ExtendStorage), 903 ExternalReference(IC_Utility(IC::kSharedStoreIC_ExtendStorage),
903 masm->isolate()), 904 masm->isolate()),
(...skipping 2847 matching lines...) Expand 10 before | Expand all | Expand 10 after
3751 TailCallBuiltin(masm, Builtins::kKeyedStoreIC_Slow); 3752 TailCallBuiltin(masm, Builtins::kKeyedStoreIC_Slow);
3752 } 3753 }
3753 } 3754 }
3754 3755
3755 3756
3756 #undef __ 3757 #undef __
3757 3758
3758 } } // namespace v8::internal 3759 } } // namespace v8::internal
3759 3760
3760 #endif // V8_TARGET_ARCH_IA32 3761 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/arm/stub-cache-arm.cc ('k') | src/x64/stub-cache-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698