Issue 16753003: Revert "Remove MediaStreamDescriptor and call/use WebMediaStream directly"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16753003: Revert "Remove MediaStreamDescriptor and call/use WebMediaStream directly" (Closed)

Created:
7 years, 6 months ago by pdr.

Modified:
7 years, 6 months ago

Reviewers:
pilgrim_google

CC:
blink-reviews, jamesr, eae+blinkwatch, abarth-chromium, feature-media-reviews_chromium.org, adamk+blink_chromium.org, jeez, vcarbune.chromium

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Revert "Remove MediaStreamDescriptor and call/use WebMediaStream directly" This reverts commit 664127105cf94ae5278ca246ca9c6c420b5b3809. This patch caused debug assertions on all debug bots: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=webaudio%2Foscillator-basic.html The assertion is "ASSERTION FAILED: !m_adoptionIsRequired" and a quick read of the patch doesn't throw up any red flags so I'll have to revert :( TBR=pilgrim@chromium.org BUG=

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+229 lines, -587 lines)			Patch
M	Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/WebKit/chromium/src/WebMediaStreamRegistry.cpp	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	Source/WebKit/chromium/src/WebUserMediaRequest.cpp	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	Source/core/core.gypi	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	Source/core/html/HTMLMediaElement.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/platform/chromium/support/WebMediaStream.cpp	View	7 chunks	+24 lines, -65 lines	0 comments	Download
D	Source/core/platform/chromium/support/WebMediaStreamClient.h	View	1 chunk	+0 lines, -50 lines	0 comments	Download
D	Source/core/platform/chromium/support/WebMediaStreamPrivate.h	View	1 chunk	+0 lines, -94 lines	0 comments	Download
D	Source/core/platform/chromium/support/WebMediaStreamPrivate.cpp	View	1 chunk	+0 lines, -131 lines	0 comments	Download
M	Source/core/platform/chromium/support/WebRTCStatsRequest.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/platform/mediastream/MediaStreamCenter.h	View	2 chunks	+7 lines, -7 lines	0 comments	Download
M	Source/core/platform/mediastream/MediaStreamCenter.cpp	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	Source/core/platform/mediastream/MediaStreamComponent.h	View	2 chunks	+6 lines, -7 lines	0 comments	Download
M	Source/core/platform/mediastream/MediaStreamComponent.cpp	View	2 chunks	+4 lines, -12 lines	0 comments	Download
A +	Source/core/platform/mediastream/MediaStreamDescriptor.h	View	2 chunks	+34 lines, -25 lines	0 comments	Download
A +	Source/core/platform/mediastream/MediaStreamDescriptor.cpp	View	4 chunks	+24 lines, -24 lines	0 comments	Download
M	Source/core/platform/mediastream/RTCPeerConnectionHandler.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/platform/mediastream/RTCPeerConnectionHandlerClient.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/platform/mediastream/RTCStatsRequest.h	View	2 chunks	+2 lines, -5 lines	0 comments	Download
M	Source/core/platform/mediastream/chromium/MediaStreamCenterChromium.h	View	2 chunks	+7 lines, -6 lines	0 comments	Download
M	Source/core/platform/mediastream/chromium/MediaStreamCenterChromium.cpp	View	4 chunks	+11 lines, -11 lines	0 comments	Download
M	Source/core/platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	Source/core/platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp	View	3 chunks	+6 lines, -7 lines	0 comments	Download
M	Source/modules/mediastream/MediaStream.h	View	5 chunks	+10 lines, -11 lines	0 comments	Download
	Source/modules/mediastream/MediaStream.cpp	View	11 chunks	+26 lines, -30 lines	0 comments	Download
M	Source/modules/mediastream/MediaStreamRegistry.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/modules/mediastream/MediaStreamRegistry.cpp	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	Source/modules/mediastream/MediaStreamTrack.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/modules/mediastream/MediaStreamTrack.cpp	View	3 chunks	+2 lines, -3 lines	0 comments	Download
M	Source/modules/mediastream/RTCDTMFSender.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/modules/mediastream/RTCPeerConnection.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/modules/mediastream/RTCPeerConnection.cpp	View	3 chunks	+8 lines, -7 lines	0 comments	Download
M	Source/modules/mediastream/RTCStatsRequestImpl.h	View	3 chunks	+2 lines, -3 lines	0 comments	Download
M	Source/modules/mediastream/RTCStatsRequestImpl.cpp	View	3 chunks	+4 lines, -6 lines	0 comments	Download
M	Source/modules/mediastream/UserMediaRequest.h	View	2 chunks	+2 lines, -5 lines	0 comments	Download
M	Source/modules/mediastream/UserMediaRequest.cpp	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/modules/webaudio/MediaStreamAudioDestinationNode.cpp	View	2 chunks	+2 lines, -6 lines	0 comments	Download
M	public/platform/WebMediaStream.h	View	2 chunks	+8 lines, -32 lines	0 comments	Download
M	public/platform/WebMediaStreamCenterClient.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	public/webpage/WebMediaStreamRegistry.h	View	1 chunk	+0 lines, -1 line	0 comments	Download