Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 16753002: Use a direct include of strings headers in chrome/test/. (Closed)

Created:
7 years, 6 months ago by Avi (use Gerrit)
Modified:
7 years, 6 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, vsevik, kkania, frankf, sail+watch_chromium.org, apatrick_chromium, chrome-speed-team+watch_google.com, rginda+watch_chromium.org, anantha, robertshield, yurys, dyu1, dennis_jeffrey, pfeldman
Visibility:
Public.

Description

Use a direct include of strings headers in chrome/test/. BUG=247723 TEST=none TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205422

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -122 lines) Patch
M chrome/test/automation/automation_json_requests.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/automation/proxy_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/automation/tab_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/automation/window_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/chrome_process_util_mac.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/base/chrome_test_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/chrome_test_suite.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/interactive_test_utils_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/test_location_bar.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/testing_browser_process.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/testing_profile_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/ui_test_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/v8_unit_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/web_ui_browsertest.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/capabilities.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/chromedriver/chrome/adb_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/chrome/console_logger.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/chrome/devtools_client_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/chrome/devtools_client_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/chrome/devtools_http_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/chrome/log.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/chromedriver/chrome/navigation_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/chrome/performance_logger.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/chrome/status.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/chrome/version.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/chrome/web_view_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/chromedriver/chrome/zip.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/chromedriver/chrome/zip_reader.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/chrome_launcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/chromedriver/command_executor_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/commands.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/element_commands.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/element_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/chromedriver/key_converter.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/key_converter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/key_converter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/keycode_text_conversion.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/keycode_text_conversion_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/net/adb_client_socket.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/chromedriver/net/net_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/net/test_http_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/net/websocket.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/server/chromedriver_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/server/http_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/chromedriver/server/http_response.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/chromedriver/util.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/test/chromedriver/window_commands.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/gpu/gpu_feature_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/gpu/gpu_pixel_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/logging/win/file_logger.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/logging/win/file_logger.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/logging/win/test_log_collector.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/mini_installer_test/installer_path_provider.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/test/mini_installer_test/installer_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/mini_installer_test/test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/perf/dom_checker_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/perf/feature_startup_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/perf/mach_ports_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/perf/memory_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/perf/perf_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/perf/perf_ui_test_suite.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/perf/rendering/latency_tests.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/perf/rendering/throughput_tests.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/perf/shutdown_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/perf/startup_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/perf/tab_switching_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/perf/url_fetch_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/ppapi/ppapi_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/pyautolib/pyautolib.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/reliability/automated_ui_tests.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/reliability/page_load_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/webdriver/commands/chrome_commands.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/webdriver/commands/cookie_commands.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/webdriver/commands/log_command.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/webdriver/commands/set_timeout_commands.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/webdriver/commands/webdriver_command.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/webdriver/commands/webelement_commands.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/webdriver/http_response.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/webdriver/keycode_text_conversion.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/webdriver/keycode_text_conversion_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/webdriver/keycode_text_conversion_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/webdriver/webdriver_automation.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/webdriver/webdriver_capabilities_parser.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/webdriver/webdriver_dispatch.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/webdriver/webdriver_dispatch_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/webdriver/webdriver_key_converter.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/webdriver/webdriver_key_converter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/webdriver/webdriver_key_converter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/webdriver/webdriver_logging.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/webdriver/webdriver_server.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/webdriver/webdriver_session.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/webdriver/webdriver_session.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/webdriver/webdriver_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16753002/1
7 years, 6 months ago (2013-06-10 19:56:52 UTC) #1
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) chrome_frame_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=160858
7 years, 6 months ago (2013-06-11 03:12:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16753002/1
7 years, 6 months ago (2013-06-11 03:38:01 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-06-11 05:07:49 UTC) #4
Message was sent while issue was closed. 
Change committed as 205422

Powered by Google App Engine
This is Rietveld 408576698