chrome/test/mini_installer_test/installer_test_util.cc - Issue 16753002: Use a direct include of strings headers in chrome/test/.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/mini_installer_test/installer_test_util.cc

Issue 16753002: Use a direct include of strings headers in chrome/test/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/test/mini_installer_test/installer_path_provider.cc ('k') | chrome/test/mini_installer_test/test.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/test/mini_installer_test/installer_test_util.h"	5 #include "chrome/test/mini_installer_test/installer_test_util.h"

6	6

7 #include "base/file_util.h"	7 #include "base/file_util.h"

8 #include "base/path_service.h"	8 #include "base/path_service.h"

9 #include "base/process.h"	9 #include "base/process.h"

10 #include "base/process_util.h"	10 #include "base/process_util.h"

11 #include "base/string_util.h"	11 #include "base/strings/string_util.h"

12 #include "base/threading/platform_thread.h"	12 #include "base/threading/platform_thread.h"

13 #include "chrome/common/chrome_result_codes.h"	13 #include "chrome/common/chrome_result_codes.h"

14 #include "chrome/installer/util/google_update_constants.h"	14 #include "chrome/installer/util/google_update_constants.h"

15 #include "chrome/installer/util/helper.h"	15 #include "chrome/installer/util/helper.h"

16 #include "chrome/installer/util/install_util.h"	16 #include "chrome/installer/util/install_util.h"

17 #include "chrome/installer/util/util_constants.h"	17 #include "chrome/installer/util/util_constants.h"

18 #include "chrome/test/mini_installer_test/mini_installer_test_constants.h"	18 #include "chrome/test/mini_installer_test/mini_installer_test_constants.h"

19 #include "testing/gtest/include/gtest/gtest.h"	19 #include "testing/gtest/include/gtest/gtest.h"

20	20

21 using installer::InstallationValidator;	21 using installer::InstallationValidator;

(...skipping 269 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
291 return false;	291 return false;

292 }	292 }

293 if (!base::WaitForSingleProcess(process, base::TimeDelta::FromMinutes(1))) {	293 if (!base::WaitForSingleProcess(process, base::TimeDelta::FromMinutes(1))) {

294 LOG(ERROR) << "Launched process did not complete.";	294 LOG(ERROR) << "Launched process did not complete.";

295 return false;	295 return false;

296 }	296 }

297 return true;	297 return true;

298 }	298 }

299	299

300 } // namespace	300 } // namespace

OLD	NEW