Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(959)

Unified Diff: build/android/device_status_check.py

Issue 16747007: Do not send alerts on slow install and make the step fail on < 15% battery. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/device_status_check.py
diff --git a/build/android/device_status_check.py b/build/android/device_status_check.py
index 0fe0b3a63fbe376ae34048385874411b275432f5..e1f8e4486e980a9aa0fd424df9478de4562a84f6 100755
--- a/build/android/device_status_check.py
+++ b/build/android/device_status_check.py
@@ -70,21 +70,23 @@ def DeviceInfo(serial):
'']
errors = []
- if battery_level < 5:
+ if battery_level < 15:
errors += ['Device critically low in battery. Do not use for testing.']
if not setup_wizard_disabled and device_build_type != 'user':
errors += ['Setup wizard not disabled. Was it provisioned correctly?']
if device_product_name == 'mantaray' and ac_power != 'true':
errors += ['Mantaray device not connected to AC power.']
- if install_speed < 800:
- errors += ['Device install speed too low. Do not use for testing.']
+ # TODO(navabi): Insert warning once we have a better handle of what install
+ # speeds to expect. The following lines were causing too many alerts.
+ # if install_speed < 500:
+ # errors += ['Device install speed too low. Do not use for testing.']
# TODO(navabi): Determine if device status check step should fail on slow
# install speed. The original CL caused the step to fail but was reverted
# because it caused too many early failures. Determine if it was just flake.
# Also, do not fail on 'Unknown' caused by offline device, because other
# devices can still be used for tests.
- fail_step = (battery_level == 'Unknown' or battery_level >= 5)
+ fail_step = (battery_level == 'Unknown' or battery_level >= 15)
return device_type, device_build, '\n'.join(report), errors, fail_step
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698