Do not send alerts on slow install and make the step fail on < 15% battery.

build/android/device_status_check.py

 #!/usr/bin/env python
 #
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """A class to keep track of devices across builds and report state."""
 import logging
 import optparse
 import os
@@ skipping 52 matching lines @@
             '  Battery: %s%%' % battery_level,
             '  Battery temp: %s' % battery_temp,
             '  IMEI slice: %s' % AdbShellCmd('dumpsys iphonesubinfo '
                                              '| grep Device'
                                              "| awk '{print $4}'")[-6:],
             '  Wifi IP: %s' % AdbShellCmd('getprop dhcp.wlan0.ipaddress'),
             '  Install Speed: %s KB/s' % install_speed,
             '']
 
   errors = []
-  if battery_level < 5:
+  if battery_level < 15:
     errors += ['Device critically low in battery. Do not use for testing.']
   if not setup_wizard_disabled and device_build_type != 'user':
     errors += ['Setup wizard not disabled. Was it provisioned correctly?']
   if device_product_name == 'mantaray' and ac_power != 'true':
     errors += ['Mantaray device not connected to AC power.']
-  if install_speed < 800:
-    errors += ['Device install speed too low. Do not use for testing.']
+  # TODO(navabi): Insert warning once we have a better handle of what install
+  # speeds to expect. The following lines were causing too many alerts.
+  # if install_speed < 500:
+  #   errors += ['Device install speed too low. Do not use for testing.']
 
   # TODO(navabi): Determine if device status check step should fail on slow
   # install speed. The original CL caused the step to fail but was reverted
   # because it caused too many early failures. Determine if it was just flake.
   # Also, do not fail on 'Unknown' caused by offline device, because other
   # devices can still be used for tests.
-  fail_step = (battery_level == 'Unknown' or battery_level >= 5)
+  fail_step = (battery_level == 'Unknown' or battery_level >= 15)
   return device_type, device_build, '\n'.join(report), errors, fail_step
 
 
 def CheckForMissingDevices(options, adb_online_devs):
   """Uses file of previous online devices to detect broken phones.
 
   Args:
     options: out_dir parameter of options argument is used as the base
              directory to load and update the cache file.
     adb_online_devs: A list of serial numbers of the currently visible
@@ skipping 118 matching lines @@
     # devices with critically low battery or install speed. Remove those devices
     # from testing, allowing build to continue with good devices.
     return 1
 
   if not devices:
     return 1
 
 
 if __name__ == '__main__':
   sys.exit(main())