Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 16747007: Do not send alerts on slow install and make the step fail on < 15% battery. (Closed)

Created:
7 years, 6 months ago by navabi
Modified:
7 years, 6 months ago
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Do not send alerts on slow install and make the step fail on < 15% battery. The slow install errors were happening too often causing too many alert emails. A few bots have had device battery problems. E.g. http://build.chromium.org/p/chromium.perf/builders/Android%20GN The device status step will fail when charge is < 15%, allowing devices to recharge before running more tests on them, and thus avoiding devices turning off and needing someone to go to the clab to restart the devices. TBR=cmp@chromium.org BUG=224004 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205912

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M build/android/device_status_check.py View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
navabi
7 years, 6 months ago (2013-06-11 08:56:07 UTC) #1
navabi
On 2013/06/11 08:56:07, navabi wrote: LGTM. I will TBR this so that we stop the ...
7 years, 6 months ago (2013-06-11 23:35:36 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 6 months ago (2013-06-11 23:36:02 UTC) #3
craigdh
lgtm.
7 years, 6 months ago (2013-06-11 23:38:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/navabi@google.com/16747007/1
7 years, 6 months ago (2013-06-11 23:40:23 UTC) #5
navabi
On 2013/06/11 23:38:36, craigdh wrote: > lgtm. Thanks Craig!
7 years, 6 months ago (2013-06-11 23:40:25 UTC) #6
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=8490
7 years, 6 months ago (2013-06-12 01:40:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/navabi@google.com/16747007/1
7 years, 6 months ago (2013-06-12 16:11:03 UTC) #8
commit-bot: I haz the power
7 years, 6 months ago (2013-06-12 20:18:55 UTC) #9
Message was sent while issue was closed.
Change committed as 205912

Powered by Google App Engine
This is Rietveld 408576698