Issue 16744004: Use a direct include of strings headers in chrome/browser/extensions/, part 4.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16744004: Use a direct include of strings headers in chrome/browser/extensions/, part 4. (Closed)

Created:
7 years, 6 months ago by Avi (use Gerrit)

Modified:
7 years, 6 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Use a direct include of strings headers in chrome/browser/extensions/, part 4. BUG=247723 TEST=none TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205253

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -37 lines)			Patch
M	chrome/browser/extensions/extension_web_ui.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extensions_quota_service_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/external_policy_loader.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/external_pref_loader.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/external_provider_impl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/external_registry_loader_win.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/installed_loader.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/isolated_app_browsertest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/media_galleries_handler.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/menu_manager.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/menu_manager.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/pack_extension_job.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/platform_app_browsertest_util.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/platform_app_launcher.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/requirements_checker_browsertest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/sandboxed_unpacker_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/script_badge_controller.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/script_badge_controller_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/startup_helper.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/test_management_policy.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/unpacked_installer.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/updater/extension_downloader.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/updater/extension_updater_unittest.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/updater/manifest_fetch_data.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/user_script_master.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/user_script_master_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/web_view_browsertest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/webstore_inline_installer.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/webstore_installer.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/webstore_installer_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/webstore_startup_installer_browsertest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/window_open_apitest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16744004/1

7 years, 6 months ago (2013-06-10 15:29:21 UTC) #1

Message was sent while issue was closed.

Change committed as 205253

Expand Messages | Collapse Messages