Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 16739016: Use a direct include of strings headers in webkit/, part 2. (Closed)

Created:
7 years, 6 months ago by Avi (use Gerrit)
Modified:
7 years, 6 months ago
CC:
chromium-reviews, michaeln, dcheng, feature-media-reviews_chromium.org, darin-cc_chromium.org, sail+watch_chromium.org, cc-bugs_chromium.org
Visibility:
Public.

Description

Use a direct include of strings headers in webkit/, part 2. BUG=247723 TEST=none TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205665

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : missing include from ordering #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -72 lines) Patch
M webkit/mocks/mock_webhyphenator.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/plugin_constants_win.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/plugin_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/plugin_lib.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/plugins/npapi/plugin_lib_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/plugin_list.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/plugin_list_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/plugin_list_posix.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/plugins/npapi/plugin_list_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/plugin_list_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/plugin_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/plugin_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/plugin_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/test/plugin_arguments_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/plugins/npapi/test/plugin_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/test/plugin_geturl_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/test/plugin_private_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/test/plugin_setup_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/test/plugin_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/test/plugin_thread_async_call_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/test/plugin_windowless_test.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webkit/plugins/npapi/test/plugin_windowless_test.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M webkit/plugins/npapi/webplugin_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/webplugin_delegate_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/webplugin_delegate_impl_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/webplugin_delegate_impl_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/plugins/npapi/webplugin_ime_win.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/webplugin_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/plugins/npapi/webplugin_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/event_conversion.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/npapi_glue.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/plugin_object.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/ppb_file_ref_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/url_request_info_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/renderer/appcache/web_application_cache_host_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/renderer/compositor_bindings/web_layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/renderer/cpp_variant.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/renderer/cpp_variant_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/renderer/dom_storage/dom_storage_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/renderer/media/audio_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/renderer/media/buffered_resource_loader.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/renderer/media/buffered_resource_loader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/renderer/media/cache_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/renderer/media/cache_util_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/renderer/media/crypto/key_systems.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/renderer/media/test_response_generator.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/support/mock_webclipboard_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/support/mock_webclipboard_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/support/platform_support_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/support/platform_support_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/support/platform_support_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M webkit/support/platform_support_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/support/simple_clipboard_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/support/simple_database_system.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/support/simple_resource_loader_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/support/test_shell_webmimeregistry_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/support/webkit_support.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16739016/1
7 years, 6 months ago (2013-06-10 23:24:18 UTC) #1
commit-bot: I haz the power
Failed to request the patch to try. Please note that binary files are still unsupported ...
7 years, 6 months ago (2013-06-10 23:24:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16739016/4001
7 years, 6 months ago (2013-06-11 15:10:10 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 6 months ago (2013-06-11 15:30:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16739016/4001
7 years, 6 months ago (2013-06-11 15:38:03 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 6 months ago (2013-06-11 15:49:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16739016/31002
7 years, 6 months ago (2013-06-11 15:59:00 UTC) #7
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 6 months ago (2013-06-11 17:24:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16739016/31002
7 years, 6 months ago (2013-06-11 17:35:21 UTC) #9
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 6 months ago (2013-06-11 18:18:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16739016/31002
7 years, 6 months ago (2013-06-11 19:00:02 UTC) #11
commit-bot: I haz the power
7 years, 6 months ago (2013-06-11 22:52:56 UTC) #12
Message was sent while issue was closed. 
Change committed as 205665

Powered by Google App Engine
This is Rietveld 408576698