Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Side by Side Diff: webkit/renderer/cpp_variant_unittest.cc

Issue 16739016: Use a direct include of strings headers in webkit/, part 2. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: missing include from ordering Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « webkit/renderer/cpp_variant.cc ('k') | webkit/renderer/dom_storage/dom_storage_proxy.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <vector> 5 #include <vector>
6 6
7 #include "base/compiler_specific.h" 7 #include "base/compiler_specific.h"
8 #include "base/string_util.h" 8 #include "base/strings/string_util.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 #include "third_party/WebKit/Source/WebKit/chromium/public/WebBindings.h" 10 #include "third_party/WebKit/Source/WebKit/chromium/public/WebBindings.h"
11 #include "webkit/renderer/cpp_variant.h" 11 #include "webkit/renderer/cpp_variant.h"
12 12
13 using WebKit::WebBindings; 13 using WebKit::WebBindings;
14 using webkit_glue::CppVariant; 14 using webkit_glue::CppVariant;
15 15
16 // Creates a std::string from an NPVariant of string type. If the NPVariant 16 // Creates a std::string from an NPVariant of string type. If the NPVariant
17 // is not a string, empties the std::string. 17 // is not a string, empties the std::string.
18 void MakeStdString(const NPVariant& np, std::string* std_string) { 18 void MakeStdString(const NPVariant& np, std::string* std_string) {
(...skipping 466 matching lines...) Expand 10 before | Expand all | Expand 10 after
485 EXPECT_TRUE(cpp_vector[1].isBool()); 485 EXPECT_TRUE(cpp_vector[1].isBool());
486 EXPECT_EQ(true, cpp_vector[1].ToBoolean()); 486 EXPECT_EQ(true, cpp_vector[1].ToBoolean());
487 487
488 EXPECT_TRUE(cpp_vector[2].isNull()); 488 EXPECT_TRUE(cpp_vector[2].isNull());
489 489
490 EXPECT_TRUE(cpp_vector[3].isString()); 490 EXPECT_TRUE(cpp_vector[3].isString());
491 CheckString("string", cpp_vector[3]); 491 CheckString("string", cpp_vector[3]);
492 492
493 WebBindings::releaseObject(obj); 493 WebBindings::releaseObject(obj);
494 } 494 }
OLDNEW
« no previous file with comments | « webkit/renderer/cpp_variant.cc ('k') | webkit/renderer/dom_storage/dom_storage_proxy.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698