Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 16736004: Stylesheet rule.cssText of content property should be quoted when the value is string. (Closed)

Created:
7 years, 6 months ago by tasak
Modified:
7 years, 6 months ago
Reviewers:
eseidel
CC:
blink-reviews, apavlov+blink_chromium.org, dglazkov+blink, eae+blinkwatch, darktears, sorvell
Visibility:
Public.

Description

PropertyContent's value should be quoted when the value is string. Since PropertyContent's value is CSSValueList, added forceQuoteString parameter to customCssText of CSSValueList and CSSPrimitiveValue. BUG=247231 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153033

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -8 lines) Patch
A LayoutTests/fast/css/csstext-of-content-string.html View 1 chunk +29 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/csstext-of-content-string-expected.txt View 1 chunk +14 lines, -0 lines 0 comments Download
M Source/core/css/CSSPrimitiveValue.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSPrimitiveValue.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSValue.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/CSSValueList.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSValueList.cpp View 1 2 chunks +5 lines, -2 lines 0 comments Download
M Source/core/css/StylePropertySerializer.cpp View 1 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tasak
To avoid regression, I didn't use quoteCSSString in CSSPrimitiveValue.cpp instead of quoteCSSStringIfNeeded. I found that ...
7 years, 6 months ago (2013-06-10 12:35:53 UTC) #1
dominicc (has gone to gerrit)
Nit inline. https://codereview.chromium.org/16736004/diff/1/Source/core/css/StylePropertySerializer.cpp File Source/core/css/StylePropertySerializer.cpp (right): https://codereview.chromium.org/16736004/diff/1/Source/core/css/StylePropertySerializer.cpp#newcode91 Source/core/css/StylePropertySerializer.cpp:91: value = toCSSValueList(property.value())->customCssText(true); Would you consider using ...
7 years, 6 months ago (2013-06-11 01:32:46 UTC) #2
tasak
Thank you for reviewing. https://codereview.chromium.org/16736004/diff/1/Source/core/css/StylePropertySerializer.cpp File Source/core/css/StylePropertySerializer.cpp (right): https://codereview.chromium.org/16736004/diff/1/Source/core/css/StylePropertySerializer.cpp#newcode91 Source/core/css/StylePropertySerializer.cpp:91: value = toCSSValueList(property.value())->customCssText(true); On 2013/06/11 ...
7 years, 6 months ago (2013-06-11 11:29:14 UTC) #3
dominicc (has gone to gerrit)
On 2013/06/11 11:29:14, tasak wrote: > Sure. Done. Looks splendid. eseidel--this is ready for you ...
7 years, 6 months ago (2013-06-11 21:06:27 UTC) #4
eseidel
lgtm Sorry, I've been on vacation.
7 years, 6 months ago (2013-06-25 21:13:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tasak@google.com/16736004/6001
7 years, 6 months ago (2013-06-25 21:15:00 UTC) #6
commit-bot: I haz the power
7 years, 6 months ago (2013-06-25 22:43:34 UTC) #7
Message was sent while issue was closed.
Change committed as 153033

Powered by Google App Engine
This is Rietveld 408576698