Source/core/css/CSSPrimitiveValue.cpp - Issue 16736004: Stylesheet rule.cssText of content property should be quoted when the value is string.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSPrimitiveValue.cpp

Issue 16736004: Stylesheet rule.cssText of content property should be quoted when the value is string. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/CSSPrimitiveValue.cpp

diff --git a/Source/core/css/CSSPrimitiveValue.cpp b/Source/core/css/CSSPrimitiveValue.cpp

index ddcf81afac82148472227faa66ed9b702cd1e016..f1d9418bcbf847edb39afd23f59308687c65b513 100644

--- a/Source/core/css/CSSPrimitiveValue.cpp

+++ b/Source/core/css/CSSPrimitiveValue.cpp

@@ -860,7 +860,7 @@ ALWAYS_INLINE static String formatNumber(double number, const char (&characters)

return formatNumber(number, characters, characterCount - 1);

}

-String CSSPrimitiveValue::customCssText() const

+String CSSPrimitiveValue::customCssText(CssTextFormattingFlags formattingFlag) const

{

// FIXME: return the original value instead of a generated one (e.g. color

// name if it was specified) - check what spec says about this

@@ -949,7 +949,7 @@ String CSSPrimitiveValue::customCssText() const

text = m_value.string;

break;

case CSS_STRING:

- text = quoteCSSStringIfNeeded(m_value.string);

+ text = formattingFlag == AlwaysQuoteCSSString ? quoteCSSString(m_value.string) : quoteCSSStringIfNeeded(m_value.string);

break;

case CSS_URI:

text = "url(" + quoteCSSURLIfNeeded(m_value.string) + ")";

« no previous file with comments | « Source/core/css/CSSPrimitiveValue.h ('k') | Source/core/css/CSSValue.h » ('j') | no next file with comments »