Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 16703020: Rewrite scoped_ptr<T>(NULL) to use the default ctor in content/. (Closed)

Created:
7 years, 6 months ago by dcheng
Modified:
7 years, 6 months ago
Reviewers:
Charlie Reis, awong
CC:
chromium-reviews, asanka, cbentzel+watch_chromium.org, vsevik, benjhayden+dwatch_chromium.org, jam, yurys, apatrick_chromium, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, rginda+watch_chromium.org, darin-cc_chromium.org, dcheng, jochen+watch_chromium.org, cc-bugs_chromium.org, pfeldman
Visibility:
Public.

Description

Rewrite scoped_ptr<T>(NULL) to use the default ctor in content/. This is the result of running the rewrite_scoped_ptr_ctor_null tool across all files built on Linux in the content/ directory. BUG=173286 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206062

Patch Set 1 #

Patch Set 2 : Clean up insanity #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -79 lines) Patch
M content/browser/browser_plugin/browser_plugin_host_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/devtools/devtools_protocol.cc View 1 chunk +1 line, -5 lines 0 comments Download
M content/browser/download/download_file_unittest.cc View 1 chunk +9 lines, -10 lines 0 comments Download
M content/browser/download/drag_download_file_browsertest.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/net/sqlite_persistent_cookie_store.cc View 2 chunks +1 line, -3 lines 0 comments Download
M content/browser/plugin_data_remover_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/touchpad_tap_suppression_controller.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/renderer_host/touchscreen_tap_suppression_controller_stub.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/session_history_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/speech/google_streaming_remote_engine.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/common/cc_messages.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/gpu_channel_manager.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/common/gpu/gpu_memory_manager_unittest.cc View 2 chunks +9 lines, -13 lines 0 comments Download
M content/common/gpu/media/gpu_video_decode_accelerator.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M content/public/test/test_renderer_host.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/renderer/device_orientation_dispatcher.cc View 1 chunk +1 line, -4 lines 0 comments Download
M content/renderer/v8_value_converter_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/shell_browser_main_parts.cc View 1 1 chunk +1 line, -10 lines 0 comments Download
M content/worker/websharedworker_stub.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
dcheng
I checked the files to make sure the formatting wasn't wildly off. If I'm lucky, ...
7 years, 6 months ago (2013-06-12 04:07:57 UTC) #1
Charlie Reis
FYI, I'm out most of this morning. You might have Albert take a first look ...
7 years, 6 months ago (2013-06-12 14:20:19 UTC) #2
Charlie Reis
Ah, he's out today. Anyway, LGTM.
7 years, 6 months ago (2013-06-12 19:45:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/16703020/3001
7 years, 6 months ago (2013-06-12 19:46:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/16703020/3001
7 years, 6 months ago (2013-06-13 02:59:11 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 6 months ago (2013-06-13 06:37:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/16703020/3001
7 years, 6 months ago (2013-06-13 12:53:11 UTC) #7
commit-bot: I haz the power
7 years, 6 months ago (2013-06-13 13:42:31 UTC) #8
Message was sent while issue was closed.
Change committed as 206062

Powered by Google App Engine
This is Rietveld 408576698