content/renderer/v8_value_converter_impl_unittest.cc - Issue 16703020: Rewrite scoped_ptr<T>(NULL) to use the default ctor in content/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/v8_value_converter_impl_unittest.cc

Issue 16703020: Rewrite scoped_ptr<T>(NULL) to use the default ctor in content/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Clean up insanity Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/v8_value_converter_impl_unittest.cc

diff --git a/content/renderer/v8_value_converter_impl_unittest.cc b/content/renderer/v8_value_converter_impl_unittest.cc

index ad9232b76929c4d690edfe3573ac6b75c5188c0d..934d8e3f636589c9762bca11ee19050e42ba0e42 100644

--- a/content/renderer/v8_value_converter_impl_unittest.cc

+++ b/content/renderer/v8_value_converter_impl_unittest.cc

@@ -365,7 +365,7 @@ TEST_F(V8ValueConverterImplTest, WeirdTypes) {

TestWeirdType(converter,

v8::Undefined(),

base::Value::TYPE_NULL, // Arbitrary type, result is NULL.

- scoped_ptr<base::Value>(NULL));

+ scoped_ptr<base::Value>());

TestWeirdType(converter,

v8::Date::New(1000),

base::Value::TYPE_DICTIONARY,