media: Enable rpath for ppapi_cdm_adapter target.

media: Enable rpath for ppapi_cdm_adapter target.

The CDM adapter is a pepper plugin and statically depends on a CDM. For example,
the widevinecdmadapter depends on widevinecdm [1].

This CL makes sure the rpath is set correctly so that we don't always need to
set LD_LIBRARY_PATH when using the CDM adapter.

[1]
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/widevine/cdm/BUILD.gn&l=129

BUG=583009
TEST=Missing dependency is fixed.

Committed: https://crrev.com/21bddfef339f2e05965a0c3cb907fd8c113f8f26
Cr-Commit-Position: refs/heads/master@{#373965}

[xhwang, 2016-02-04 22:01:21]

xhwang@chromium.org changed reviewers:
+ brettw@chromium.org

[xhwang, 2016-02-04 22:01:21]

For now, this seems to be the best way I can find, even though this should only
be used for tests. Suggestions are more than welcome!

This will not be needed after this is fixed:
https://code.google.com/p/chromium/issues/detail?id=403462

PTAL!

[brettw, 2016-02-04 22:45:24]

If this is only used for tests, how do we normally ship CDM's? I see a
"widevinecdmadapter" target that seems to be not test code. If it's really only
test code, can we set testonly on the generated target?

If it's not test code, then setting this scares me and we should check with some
Linux experts that this is OK.

[xhwang, 2016-02-04 22:54:16]

On 2016/02/04 22:45:24, brettw wrote:
> If this is only used for tests, how do we normally ship CDM's? I see a
> "widevinecdmadapter" target that seems to be not test code. If it's really
only
> test code, can we set testonly on the generated target?
> 
> If it's not test code, then setting this scares me and we should check with
some
> Linux experts that this is OK.

Sorry for the confusion.

This is NOT test code. The CDM adapter and CDM are shipped in production.

Could you please recommend a Linux expert to review this change?

[brettw, 2016-02-04 22:57:27]

Before escalating, what does the GYP build do?

[xhwang, 2016-02-04 23:01:40]

On 2016/02/04 22:57:27, brettw wrote:
> Before escalating, what does the GYP build do?

'ldflags': ['-Wl,-rpath=\$$ORIGIN'],

https://code.google.com/p/chromium/codesearch#chromium/src/media/media_cdm_ad...

[brettw, 2016-02-04 23:04:33]

brettw@chromium.org changed reviewers:
+ thestig@chromium.org

[brettw, 2016-02-04 23:04:34]

Lei, can you double-check that setting rpath on this .so we distribute is the
correct thing (or forward it to somebody who can)? I don't actually know how the
rpaths work and I don't want to open a sandbox hole.

[Lei Zhang, 2016-02-05 19:31:54]

lgtm based on the discussion on the bug.

[xhwang, 2016-02-05 23:18:27]

The CQ bit was checked by xhwang@chromium.org

[commit-bot: I haz the power, 2016-02-05 23:18:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1669923002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1669923002/1

[commit-bot: I haz the power, 2016-02-06 00:24:32]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-06 00:26:33]

Description was changed from

==========
media: Enable rpath for ppapi_cdm_adapter target.

The CDM adapter is a pepper plugin and statically depends on a CDM. For example,
the widevinecdmadapter depends on widevinecdm [1].

This CL makes sure the rpath is set correctly so that we don't always need to
set LD_LIBRARY_PATH when using the CDM adapter.

[1]
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/widevi...

BUG=583009
TEST=Missing dependency is fixed.
==========

to

==========
media: Enable rpath for ppapi_cdm_adapter target.

The CDM adapter is a pepper plugin and statically depends on a CDM. For example,
the widevinecdmadapter depends on widevinecdm [1].

This CL makes sure the rpath is set correctly so that we don't always need to
set LD_LIBRARY_PATH when using the CDM adapter.

[1]
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/widevi...

BUG=583009
TEST=Missing dependency is fixed.

Committed: https://crrev.com/21bddfef339f2e05965a0c3cb907fd8c113f8f26
Cr-Commit-Position: refs/heads/master@{#373965}
==========

[commit-bot: I haz the power, 2016-02-06 00:26:33]

Patchset 1 (id:??) landed as
https://crrev.com/21bddfef339f2e05965a0c3cb907fd8c113f8f26
Cr-Commit-Position: refs/heads/master@{#373965}