Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 16690004: [CSS Regions] Rename region-overflow to region-fragment (Closed)

Created:
7 years, 6 months ago by stavila
Modified:
7 years, 6 months ago
Reviewers:
apavlov
CC:
blink-reviews, chromiumbugtracker_adobe.com, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, apavlov+blink_chromium.org, jchaffraix+rendering, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

[CSS Regions] Rename region-overflow to region-fragment Renamed -webkit-region-overflow to -webkit-region-fragment and webkitRegionOverflow to webkitRegionFragment according to the new working draft at http://www.w3.org/TR/2013/WD-css3-regions-20130528/#the-region-fragment-property BUG=248069 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152212

Patch Set 1 #

Patch Set 2 : Patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -145 lines) Patch
M LayoutTests/fast/regions/autoheight-breakafteralways-maxheight.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/regions/autoheight-breakbeforealways.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/regions/autoheight-singleregion-breakafteralways.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/regions/autoheight-singleregion-breakafteralways-maxheight.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/regions/autoheight-singleregion-breakaftermargin.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/regions/autoheight-singleregion-breakbeforealways.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/regions/autoheight-singleregion-breakbeforealways-minheight.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/regions/autoheight-singleregion-multiplebreaks.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/regions/css-regions-disabled-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/regions/region-overflow-auto-overflow-hidden.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/regions/region-overflow-auto-overflow-visible.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/regions/region-overflow-break.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/regions/regions-widows-and-orphans.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/regions/script-tests/css-regions-disabled.js View 3 chunks +9 lines, -9 lines 0 comments Download
A + LayoutTests/fast/regions/script-tests/webkit-region-fragment-parsing.js View 1 chunk +13 lines, -13 lines 0 comments Download
D LayoutTests/fast/regions/script-tests/webkit-region-overflow-parsing.js View 1 chunk +0 lines, -37 lines 0 comments Download
A + LayoutTests/fast/regions/webkit-region-fragment-parsing.html View 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/fast/regions/webkit-region-fragment-parsing-expected.txt View 1 chunk +25 lines, -0 lines 0 comments Download
D LayoutTests/fast/regions/webkit-region-overflow-parsing.html View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/fast/regions/webkit-region-overflow-parsing-expected.txt View 1 chunk +0 lines, -25 lines 0 comments Download
M LayoutTests/webexposed/css-properties-as-js-properties-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M PerformanceTests/Layout/resources/regions.css View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/CSSParser.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/CSSPrimitiveValueMappings.h View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/core/css/CSSProperties.in View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSProperty.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSPropertyNames.in View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSValueKeywords.in View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/RuntimeCSSEnabled.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/UseCounter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderRegion.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/style/RenderStyle.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/style/RenderStyle.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/style/RenderStyleConstants.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/style/StyleRareNonInheritedData.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/style/StyleRareNonInheritedData.cpp View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
apavlov
lgtm
7 years, 6 months ago (2013-06-10 14:59:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stavila@adobe.com/16690004/1
7 years, 6 months ago (2013-06-10 14:59:44 UTC) #2
commit-bot: I haz the power
Retried try job too often on mac_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout_rel&number=9241
7 years, 6 months ago (2013-06-10 16:56:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stavila@adobe.com/16690004/1
7 years, 6 months ago (2013-06-11 08:12:45 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=12264
7 years, 6 months ago (2013-06-11 09:00:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stavila@adobe.com/16690004/23001
7 years, 6 months ago (2013-06-11 09:30:12 UTC) #6
commit-bot: I haz the power
7 years, 6 months ago (2013-06-11 11:00:54 UTC) #7
Message was sent while issue was closed. 
Change committed as 152212

Powered by Google App Engine
This is Rietveld 408576698