Source/core/rendering/RenderRegion.cpp - Issue 16690004: [CSS Regions] Rename region-overflow to region-fragment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderRegion.cpp

Issue 16690004: [CSS Regions] Rename region-overflow to region-fragment (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Patch Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/RenderRegion.cpp

diff --git a/Source/core/rendering/RenderRegion.cpp b/Source/core/rendering/RenderRegion.cpp

index 071a20b79b7f3221e745a6dbaa413067bf7e7801..5bb9041da655144e110583a36d6ee676f244f705 100644

--- a/Source/core/rendering/RenderRegion.cpp

+++ b/Source/core/rendering/RenderRegion.cpp

@@ -100,8 +100,8 @@ LayoutRect RenderRegion::overflowRectForFlowThreadPortion(const LayoutRect& flow

// folded into RenderBlock, switch to hasOverflowClip().

bool clipX = style()->overflowX() != OVISIBLE;

bool clipY = style()->overflowY() != OVISIBLE;

- bool isLastRegionWithRegionOverflowBreak = (isLastPortion && (style()->regionOverflow() == BreakRegionOverflow));

- if ((clipX && clipY) || isLastRegionWithRegionOverflowBreak)

+ bool isLastRegionWithRegionFragmentBreak = (isLastPortion && (style()->regionFragment() == BreakRegionFragment));

+ if ((clipX && clipY) || isLastRegionWithRegionFragmentBreak)

return flowThreadPortionRect;

LayoutRect flowThreadOverflow = m_flowThread->visualOverflowRect();

« no previous file with comments | « Source/core/rendering/RenderBlock.cpp ('k') | Source/core/rendering/style/RenderStyle.h » ('j') | no next file with comments »