Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 16688002: Port remaining android buildbot code into python (Closed)

Created:
7 years, 6 months ago by Isaac (away)
Modified:
7 years, 6 months ago
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach, Yaron, klundberg+watch_chromium.org, frankf+watch_chromium.org, navabi1
Visibility:
Public.

Description

Port remaining android buildbot code into python - Run envsetup.sh and retrieve environment rather than wrapping commands in a bash shell. Consolidate remaining PATH code. This also cleans up the preamble output. - Port android landmine code to python. - Simplified testing command layout in bb_run_bot. - Change bb_run_bot_test to run in parallel. - Fixed bug where dbg clobber affects release bot using same checkout - Made step names more similar to other chromium bots. - Consolidated factory-prop and build-prop parsing code. BUG=176126 NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205244

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -239 lines) Patch
M build/android/buildbot/bb_device_steps.py View 1 chunk +0 lines, -11 lines 0 comments Download
M build/android/buildbot/bb_host_steps.py View 1 7 chunks +29 lines, -28 lines 0 comments Download
M build/android/buildbot/bb_run_bot.py View 1 6 chunks +91 lines, -95 lines 0 comments Download
M build/android/buildbot/bb_utils.py View 1 5 chunks +11 lines, -8 lines 0 comments Download
D build/android/buildbot/buildbot_functions.sh View 1 chunk +0 lines, -92 lines 0 comments Download
A build/android/buildbot/env_to_json.py View 1 1 chunk +11 lines, -0 lines 0 comments Download
M build/android/buildbot/tests/bb_run_bot_test.py View 1 chunk +7 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Isaac (away)
go/supersecret/23643638
7 years, 6 months ago (2013-06-08 05:36:46 UTC) #1
Isaac (away)
7 years, 6 months ago (2013-06-09 01:56:25 UTC) #2
iannucci
lgtm. This will make the conversion to recipes easier :)
7 years, 6 months ago (2013-06-09 03:26:32 UTC) #3
bulach
lgtm (not aware of all the details, but more python less bash looks fine by ...
7 years, 6 months ago (2013-06-10 17:39:44 UTC) #4
Siva Chandra
lgtm
7 years, 6 months ago (2013-06-10 17:48:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ilevy@chromium.org/16688002/38002
7 years, 6 months ago (2013-06-10 17:52:53 UTC) #6
commit-bot: I haz the power
Change committed as 205244
7 years, 6 months ago (2013-06-10 17:53:27 UTC) #7
Siva Chandra
Did we miss the presubmit bot failures because we bypassed the CQ?
7 years, 6 months ago (2013-06-11 19:43:33 UTC) #8
iannucci
On 2013/06/11 19:43:33, Siva Chandra wrote: > Did we miss the presubmit bot failures because ...
7 years, 6 months ago (2013-06-11 20:10:43 UTC) #9
Siva Chandra
On 2013/06/11 20:10:43, iannucci wrote: > On 2013/06/11 19:43:33, Siva Chandra wrote: > > Did ...
7 years, 6 months ago (2013-06-11 20:25:31 UTC) #10
Isaac (away)
7 years, 6 months ago (2013-06-12 05:27:51 UTC) #11
Message was sent while issue was closed.
On 2013/06/11 20:10:43, iannucci wrote:
> On 2013/06/11 19:43:33, Siva Chandra wrote:
> > Did we miss the presubmit bot failures because we bypassed the CQ?
> 
> Which presubmit bot failures?
> 
> Yeah, currently presubmit respects NOTRY... That's probably a bug.

I thought we intended to have presubmit always run (since it was already run
before
off loading).

I am fixing this error in https://chromiumcodereview.appspot.com/16708003/

Powered by Google App Engine
This is Rietveld 408576698