Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 16684003: Use a direct include of strings headers in ipc/, jingle/, media/. (Closed)

Created:
7 years, 6 months ago by Avi (use Gerrit)
Modified:
7 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, sail+watch_chromium.org, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Use a direct include of strings headers in ipc/, jingle/, media/. BUG=247723 TEST=none TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205436

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -69 lines) Patch
M ipc/ipc_channel.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_channel_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_channel_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_logging.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M ipc/ipc_message_utils.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ipc/ipc_message_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_perftests.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ipc/ipc_sync_channel_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M jingle/notifier/communicator/single_login_attempt.cc View 1 chunk +1 line, -1 line 0 comments Download
M jingle/notifier/listener/notification_defines.cc View 1 chunk +1 line, -1 line 0 comments Download
M jingle/notifier/listener/notification_defines_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M jingle/notifier/listener/push_notifications_send_update_task_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M jingle/notifier/listener/push_notifications_subscribe_task_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M jingle/notifier/listener/xml_element_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/audio_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/audio_parameters_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/audio_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/linux/alsa_output_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/win/audio_manager_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/audio/win/core_audio_util_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/android/media_codec_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/audio_bus_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/audio_converter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/audio_hash.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/audio_pull_fifo_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/channel_mixer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/data_buffer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/decoder_buffer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/pipeline.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M media/base/sinc_resampler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/vector_math_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/video_frame_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/crypto/aes_decryptor.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/ffmpeg/ffmpeg_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/audio_renderer_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/ffmpeg_audio_decoder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/ffmpeg_demuxer.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/ffmpeg_video_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/ffmpeg_video_decoder_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/filters/pipeline_integration_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/source_buffer_stream_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/filters/stream_parser_factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/filters/video_renderer_base_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/vpx_video_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/test/ffmpeg_tests/ffmpeg_tests.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/tools/demuxer_bench/demuxer_bench.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/tools/media_bench/media_bench.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/tools/seek_tester/seek_tester.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/tools/shader_bench/shader_bench.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/video/capture/android/video_capture_device_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/video/capture/fake_video_capture_device.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/video/capture/linux/video_capture_device_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/video/capture/win/video_capture_device_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/webm/webm_tracks_parser.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16684003/1
7 years, 6 months ago (2013-06-10 21:30:44 UTC) #1
commit-bot: I haz the power
7 years, 6 months ago (2013-06-11 06:32:21 UTC) #2
Message was sent while issue was closed. 
Change committed as 205436

Powered by Google App Engine
This is Rietveld 408576698