Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 16654009: Rewrite scoped_ptr<T>(NULL) to use the default ctor in sync/. (Closed)

Created:
7 years, 6 months ago by dcheng
Modified:
7 years, 6 months ago
Reviewers:
rlarocque
CC:
chromium-reviews, Raghu Simha, haitaol1, akalin, tim (not reviewing)
Visibility:
Public.

Description

Rewrite scoped_ptr<T>(NULL) to use the default ctor in sync/. This is the result of running the rewrite_scoped_ptr_ctor_null tool across all files built on Linux in the sync/ directory. BUG=173286 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205919

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M sync/engine/sync_scheduler_unittest.cc View 1 chunk +1 line, -5 lines 0 comments Download
M sync/syncable/directory_backing_store.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/test/engine/mock_connection_manager.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dcheng
7 years, 6 months ago (2013-06-12 03:51:30 UTC) #1
rlarocque
lgtm
7 years, 6 months ago (2013-06-12 17:11:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/16654009/1
7 years, 6 months ago (2013-06-12 17:28:41 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-06-12 20:34:12 UTC) #4
Message was sent while issue was closed.
Change committed as 205919

Powered by Google App Engine
This is Rietveld 408576698