sync/syncable/directory_backing_store.cc - Issue 16654009: Rewrite scoped_ptr<T>(NULL) to use the default ctor in sync/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/syncable/directory_backing_store.cc

Issue 16654009: Rewrite scoped_ptr<T>(NULL) to use the default ctor in sync/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sync/syncable/directory_backing_store.cc

diff --git a/sync/syncable/directory_backing_store.cc b/sync/syncable/directory_backing_store.cc

index f37ecc1b88cdcf9c8c369091fc7acdd00f6f549f..0f4e060ce48286dc36af8f41f93eb95ce7e454c0 100644

--- a/sync/syncable/directory_backing_store.cc

+++ b/sync/syncable/directory_backing_store.cc

@@ -108,7 +108,7 @@ scoped_ptr<EntryKernel> UnpackEntry(sql::Statement* statement) {

sync_pb::UniquePosition proto;

if (!proto.ParseFromString(temp)) {

DVLOG(1) << "Unpacked invalid position. Assuming the DB is corrupt";

- return scoped_ptr<EntryKernel>(NULL);

+ return scoped_ptr<EntryKernel>();

}

kernel->mutable_ref(static_cast<UniquePositionField>(i)) =

« no previous file with comments | « sync/engine/sync_scheduler_unittest.cc ('k') | sync/test/engine/mock_connection_manager.cc » ('j') | no next file with comments »