Issue 16633004: Android: Don't push layout_tests data for content browser tests.

Issue 16633004: Android: Don't push layout_tests data for content browser tests. (Closed)

Created:
7 years, 6 months ago by nilesh

Modified:
7 years, 6 months ago

Reviewers:
Yaron, Isaac (away), frankf

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Android: Don't push layout_tests data for content browser tests. These tests are now deleted. See: crbug.com/247459 Also disable some tests which were enabled but not fixed. See: https://codereview.chromium.org/16268011 BUG=238485 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205638

Patch Set 1 #

Patch Set 2 : Disable failing tests. #

Patch Set 3 : #

Total comments: 4

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -17 lines)			Patch
M	build/android/buildbot/bb_device_steps.py	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	build/android/pylib/gtest/filter/content_browsertests_disabled	View	1 2	1 chunk	+12 lines, -0 lines	2 comments	Download
M	build/android/pylib/gtest/test_runner.py	View	1 2	1 chunk	+0 lines, -16 lines	2 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

frankf

https://codereview.chromium.org/16633004/diff/11002/build/android/pylib/gtest/filter/content_browsertests_disabled File build/android/pylib/gtest/filter/content_browsertests_disabled (right): https://codereview.chromium.org/16633004/diff/11002/build/android/pylib/gtest/filter/content_browsertests_disabled#newcode86 build/android/pylib/gtest/filter/content_browsertests_disabled:86: BookmarkletTest.NonEmptyResult Is there a bug for these failures? https://codereview.chromium.org/16633004/diff/11002/build/android/pylib/gtest/test_runner.py ...

7 years, 6 months ago (2013-06-11 18:58:20 UTC) #2

nilesh

https://codereview.chromium.org/16633004/diff/11002/build/android/pylib/gtest/filter/content_browsertests_disabled File build/android/pylib/gtest/filter/content_browsertests_disabled (right): https://codereview.chromium.org/16633004/diff/11002/build/android/pylib/gtest/filter/content_browsertests_disabled#newcode86 build/android/pylib/gtest/filter/content_browsertests_disabled:86: BookmarkletTest.NonEmptyResult On 2013/06/11 18:58:20, frankf wrote: > Is there ...

7 years, 6 months ago (2013-06-11 19:19:00 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/16633004/11002

7 years, 6 months ago (2013-06-11 20:27:52 UTC) #6

commit-bot: I haz the power

Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=8402

7 years, 6 months ago (2013-06-11 20:38:28 UTC) #7

nilesh

Looks like there is a presubmit issue with build/android/buildbot : https://chromiumcodereview.appspot.com/16688002 Landing with NOTRY

7 years, 6 months ago (2013-06-11 21:22:50 UTC) #8

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/16633004/11002

7 years, 6 months ago (2013-06-11 21:26:46 UTC) #9

Message was sent while issue was closed.

Change committed as 205638

Expand Messages | Collapse Messages