Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(899)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 16632010: Use a direct include of strings headers in extensions/, google_apis/, gpu/. (Closed)

Created:
7 years, 6 months ago by Avi (use Gerrit)
Modified:
7 years, 6 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, sail+watch_chromium.org, apatrick_chromium, extensions-reviews_chromium.org
Visibility:
Public.

Description

Use a direct include of strings headers in extensions/, google_apis/, gpu/. BUG=247723 TEST=none TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205460

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -66 lines) Patch
M extensions/common/error_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/error_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/id_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/common/matcher/regex_set_matcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/matcher/url_matcher_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/matcher/url_matcher_factory_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/matcher/url_matcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/url_pattern.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M google_apis/cup/client_update_protocol.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M google_apis/gaia/gaia_auth_fetcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M google_apis/gaia/gaia_auth_fetcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gaia/gaia_auth_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gaia/gaia_oauth_client_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M google_apis/gaia/google_service_auth_error.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M google_apis/gaia/oauth2_access_token_fetcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M google_apis/gaia/oauth2_api_call_flow.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gaia/oauth2_mint_token_flow.h View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gaia/oauth2_mint_token_flow.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M google_apis/gaia/oauth_request_signer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/context_group.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/error_state.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/feature_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/framebuffer_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gpu_tracer.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/logger.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/memory_program_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/program_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/program_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/renderbuffer_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/shader_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/texture_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/vertex_attrib_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/config/gpu_control_list.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/config/gpu_dx_diagnostics_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/config/gpu_info_collector.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/config/gpu_info_collector_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/config/gpu_info_collector_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/config/gpu_info_collector_win.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M gpu/config/gpu_info_collector_x11.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/config/gpu_test_expectations_parser.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16632010/1
7 years, 6 months ago (2013-06-10 21:24:20 UTC) #1
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 6 months ago (2013-06-11 01:37:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16632010/1
7 years, 6 months ago (2013-06-11 03:41:15 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-06-11 07:29:23 UTC) #4
Message was sent while issue was closed. 
Change committed as 205460

Powered by Google App Engine
This is Rietveld 408576698