Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 16632008: Use a direct include of strings headers in chrome/browser/ui/webui/, part 1. (Closed)

Created:
7 years, 6 months ago by Avi (use Gerrit)
Modified:
7 years, 6 months ago
CC:
chromium-reviews, skanuj+watch_chromium.org, nkostylev+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, mad+watch_chromium.org, stevenjb+watch_chromium.org, extensions-reviews_chromium.org, vsevik, melevin+watch_chromium.org, dominich, chromium-apps-reviews_chromium.org, tbarzic+watch_chromium.org, jfweitz+watch_chromium.org, pam+watch_chromium.org, oshima+watch_chromium.org, Jered, donnd+watch_chromium.org, yurys, eroman, David Black, mmenke, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, pfeldman
Visibility:
Public.

Description

Use a direct include of strings headers in chrome/browser/ui/webui/, part 1. BUG=247723 TEST=none TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205285

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -43 lines) Patch
M chrome/browser/ui/webui/about_ui.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/drive_internals_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/imageburner/imageburner_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/base_screen_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/base_screen_handler_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/locally_managed_user_creation_screen_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/system_info_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/cookies_tree_model_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/devtools_ui.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_icon_source.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_info_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/install_extension_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/install_extension_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/feedback_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/flash_ui.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/help/help_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/help/help_utils_chromeos.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/help/version_updater.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/help/version_updater_basic.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/help/version_updater_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/history_ui.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/history_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/inline_login_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/inspect_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/instant_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/memory_internals/memory_internals_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/memory_internals/memory_internals_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/memory_internals/memory_internals_proxy.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/nacl_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/net_export_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/net_internals/net_internals_ui.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16632008/1
7 years, 6 months ago (2013-06-10 16:37:30 UTC) #1
commit-bot: I haz the power
7 years, 6 months ago (2013-06-10 20:11:38 UTC) #2
Message was sent while issue was closed. 
Change committed as 205285

Powered by Google App Engine
This is Rietveld 408576698