chrome/browser/geolocation/chrome_geolocation_permission_context.cc - Issue 16625012: Remove ExtensionURLInfo, make security decisions in render process

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/geolocation/chrome_geolocation_permission_context.cc

Issue 16625012: Remove ExtensionURLInfo, make security decisions in render process (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: address feedback Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/geolocation/chrome_geolocation_permission_context.cc

diff --git a/chrome/browser/geolocation/chrome_geolocation_permission_context.cc b/chrome/browser/geolocation/chrome_geolocation_permission_context.cc

index e81d95027eac7072f25e5366645c316b8c5d9614..37826024e37d70b5c785f3ad69b546671e436040 100644

--- a/chrome/browser/geolocation/chrome_geolocation_permission_context.cc

+++ b/chrome/browser/geolocation/chrome_geolocation_permission_context.cc

@@ -71,9 +71,7 @@ void ChromeGeolocationPermissionContext::RequestGeolocationPermission(

if (extension_service) {

const extensions::Extension* extension =

extension_service->extensions()->GetExtensionOrAppByURL(

- ExtensionURLInfo(WebKit::WebSecurityOrigin::createFromString(

- UTF8ToUTF16(requesting_frame.spec())),

- requesting_frame));

+ requesting_frame);

if (IsExtensionWithPermissionOrSuggestInConsole(APIPermission::kGeolocation,

extension,

profile_)) {

« no previous file with comments | « chrome/browser/extensions/tab_helper.cc ('k') | chrome/browser/media/media_stream_capture_indicator.cc » ('j') | no next file with comments »