chrome/browser/extensions/tab_helper.cc - Issue 16625012: Remove ExtensionURLInfo, make security decisions in render process

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/tab_helper.cc

Issue 16625012: Remove ExtensionURLInfo, make security decisions in render process (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: address feedback Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/tab_helper.cc

diff --git a/chrome/browser/extensions/tab_helper.cc b/chrome/browser/extensions/tab_helper.cc

index cfd07b72101bc249b1ba1f8070c80ea38268bf07..ac7620c4440e913eda0cd8664c35a0196566ac0f 100644

--- a/chrome/browser/extensions/tab_helper.cc

+++ b/chrome/browser/extensions/tab_helper.cc

@@ -311,11 +311,10 @@ void TabHelper::OnGetAppInstallState(const GURL& requestor_url,

const ExtensionSet* extensions = extension_service->extensions();

const ExtensionSet* disabled = extension_service->disabled_extensions();

- ExtensionURLInfo url(requestor_url);

std::string state;

- if (extensions->GetHostedAppByURL(url))

+ if (extensions->GetHostedAppByURL(requestor_url))

state = extension_misc::kAppStateInstalled;

- else if (disabled->GetHostedAppByURL(url))

+ else if (disabled->GetHostedAppByURL(requestor_url))

state = extension_misc::kAppStateDisabled;

else

state = extension_misc::kAppStateNotInstalled;