Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: components/autofill/browser/autofill_xml_parser_unittest.cc

Issue 16611003: Ignore ajax on specified pages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: unittests Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/browser/autofill_xml_parser_unittest.cc
diff --git a/components/autofill/browser/autofill_xml_parser_unittest.cc b/components/autofill/browser/autofill_xml_parser_unittest.cc
index b0922c07ef47debd5afd235f2ebc367a9075f1a3..47eba838db607f2627209d604e99ea9065bd8a7c 100644
--- a/components/autofill/browser/autofill_xml_parser_unittest.cc
+++ b/components/autofill/browser/autofill_xml_parser_unittest.cc
@@ -179,6 +179,7 @@ TEST_F(AutofillQueryXmlParserTest, ParseAutofillFlow) {
EXPECT_EQ(1U, field_infos_.size());
EXPECT_EQ(1, page_meta_data_.current_page_number);
EXPECT_EQ(10, page_meta_data_.total_pages);
+ EXPECT_FALSE(page_meta_data_.ignore_ajax);
EXPECT_EQ("foo", page_meta_data_.proceed_element_descriptor.descriptor);
EXPECT_EQ(autofill::WebElementDescriptor::ID,
page_meta_data_.proceed_element_descriptor.retrieval_method);
@@ -277,6 +278,29 @@ TEST_F(AutofillQueryXmlParserTest, ParseAutofillFlow) {
click_elment = page_meta_data_.click_elements_after_form_fill[0];
EXPECT_EQ("btn1", click_elment.descriptor);
EXPECT_EQ(autofill::WebElementDescriptor::ID, click_elment.retrieval_method);
+
+ // Clear |field_infos_| for the next test;
Ilya Sherman 2013/06/11 01:11:20 nit: semicolon -> period
Dane Wallinga 2013/06/11 19:03:32 Done.
+ field_infos_.clear();
+
+ // Test setting of ignore_ajax attribute.
+ xml = "<autofillqueryresponse>"
+ "<field autofilltype=\"55\"/>"
+ "<autofill_flow page_no=\"1\" total_pages=\"10\" ignore_ajax=\"true\">"
+ "<page_advance_button css_selector=\"[name=&quot;foo&quot;]\""
+ " id=\"foo\"/>"
+ "</autofill_flow>"
+ "</autofillqueryresponse>";
+
+ ParseQueryXML(xml, true);
+
+ EXPECT_EQ(1U, field_infos_.size());
+ EXPECT_EQ(1, page_meta_data_.current_page_number);
+ EXPECT_EQ(10, page_meta_data_.total_pages);
+ EXPECT_TRUE(page_meta_data_.ignore_ajax);
Ilya Sherman 2013/06/11 01:11:20 nit: Please include a negative test case as well.
Dane Wallinga 2013/06/11 19:03:32 Line 182
+ EXPECT_EQ("[name=\"foo\"]",
+ page_meta_data_.proceed_element_descriptor.descriptor);
+ EXPECT_EQ(autofill::WebElementDescriptor::CSS_SELECTOR,
+ page_meta_data_.proceed_element_descriptor.retrieval_method);
}
// Test badly formed XML queries.

Powered by Google App Engine
This is Rietveld 408576698