Ignore ajax on specified pages.

components/autofill/browser/autofill_xml_parser_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 #include <vector>
 
 #include "base/memory/scoped_ptr.h"
 #include "base/strings/string_number_conversions.h"
 #include "components/autofill/browser/autocheckout_page_meta_data.h"
@@ skipping 161 matching lines @@
                     "<autofill_flow page_no=\"1\" total_pages=\"10\">"
                     "<page_advance_button id=\"foo\"/>"
                     "</autofill_flow>"
                     "</autofillqueryresponse>";
 
   ParseQueryXML(xml, true);
 
   EXPECT_EQ(1U, field_infos_.size());
   EXPECT_EQ(1, page_meta_data_.current_page_number);
   EXPECT_EQ(10, page_meta_data_.total_pages);
+  EXPECT_FALSE(page_meta_data_.ignore_ajax);
   EXPECT_EQ("foo", page_meta_data_.proceed_element_descriptor.descriptor);
   EXPECT_EQ(autofill::WebElementDescriptor::ID,
             page_meta_data_.proceed_element_descriptor.retrieval_method);
 
   // Clear |field_infos_| for the next test;
   field_infos_.clear();
 
   // Test css_selector as page_advance_button.
   xml = "<autofillqueryresponse>"
         "<field autofilltype=\"55\"/>"
@@ skipping 78 matching lines @@
 
   ParseQueryXML(xml, true);
 
   EXPECT_EQ(1U, field_infos_.size());
   EXPECT_EQ(1, page_meta_data_.current_page_number);
   EXPECT_EQ(10, page_meta_data_.total_pages);
   ASSERT_EQ(1U, page_meta_data_.click_elements_after_form_fill.size());
   click_elment = page_meta_data_.click_elements_after_form_fill[0];
   EXPECT_EQ("btn1", click_elment.descriptor);
   EXPECT_EQ(autofill::WebElementDescriptor::ID, click_elment.retrieval_method);
+
+  // Clear |field_infos_| for the next test;

[Ilya Sherman, 2013/06/11 01:11:20]

nit: semicolon -> period

[Dane Wallinga, 2013/06/11 19:03:32]

Done.

+  field_infos_.clear();
+
+  // Test setting of ignore_ajax attribute.
+  xml = "<autofillqueryresponse>"
+        "<field autofilltype=\"55\"/>"
+        "<autofill_flow page_no=\"1\" total_pages=\"10\" ignore_ajax=\"true\">"
+        "<page_advance_button css_selector=\"[name=&quot;foo&quot;]\""
+        " id=\"foo\"/>"
+        "</autofill_flow>"
+        "</autofillqueryresponse>";
+
+  ParseQueryXML(xml, true);
+
+  EXPECT_EQ(1U, field_infos_.size());
+  EXPECT_EQ(1, page_meta_data_.current_page_number);
+  EXPECT_EQ(10, page_meta_data_.total_pages);
+  EXPECT_TRUE(page_meta_data_.ignore_ajax);

[Ilya Sherman, 2013/06/11 01:11:20]

nit: Please include a negative test case as well.

[Dane Wallinga, 2013/06/11 19:03:32]

Line 182

+  EXPECT_EQ("[name=\"foo\"]",
+            page_meta_data_.proceed_element_descriptor.descriptor);
+  EXPECT_EQ(autofill::WebElementDescriptor::CSS_SELECTOR,
+            page_meta_data_.proceed_element_descriptor.retrieval_method);
 }
 
 // Test badly formed XML queries.
 TEST_F(AutofillQueryXmlParserTest, ParseErrors) {
   // Test no Autofill type.
   std::string xml = "<autofillqueryresponse>"
                     "<field/>"
                     "</autofillqueryresponse>";
 
   ParseQueryXML(xml, false);
@@ skipping 76 matching lines @@
   EXPECT_DOUBLE_EQ(0, negative_);
 
   ParseUploadXML(std::string(), false);
 
   EXPECT_DOUBLE_EQ(0, positive_);
   EXPECT_DOUBLE_EQ(0, negative_);
 }
 
 }  // namespace
 }  // namespace autofill