Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 16566006: Speculatively fix and re-enable DownloadFileRequest_NonExistentFile. (Closed)

Created:
7 years, 6 months ago by kinaba
Modified:
7 years, 6 months ago
Reviewers:
hashimoto
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Speculatively fix and re-enable DownloadFileRequest_NonExistentFile. The test for an error case is trying to open a file with an empty path. That looks scary. BUG=169588 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205182

Patch Set 1 #

Patch Set 2 : Fix? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M chrome/browser/google_apis/base_requests_server_unittest.cc View 1 2 chunks +1 line, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kinaba
I'm still not 100% confident (I couldn't reproduce it on trybots yet), but the code ...
7 years, 6 months ago (2013-06-10 08:14:30 UTC) #1
hashimoto
lgtm
7 years, 6 months ago (2013-06-10 08:27:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/16566006/3001
7 years, 6 months ago (2013-06-10 08:32:18 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-06-10 10:37:55 UTC) #4
Message was sent while issue was closed.
Change committed as 205182

Powered by Google App Engine
This is Rietveld 408576698