Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5047)

Unified Diff: chrome/browser/google_apis/base_requests_server_unittest.cc

Issue 16566006: Speculatively fix and re-enable DownloadFileRequest_NonExistentFile. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix? Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/google_apis/base_requests_server_unittest.cc
diff --git a/chrome/browser/google_apis/base_requests_server_unittest.cc b/chrome/browser/google_apis/base_requests_server_unittest.cc
index 64179d8ca60f05054ebd2f74f774560fc4cfda33..836bf550c8d7cf0059b1070965163bda41541560 100644
--- a/chrome/browser/google_apis/base_requests_server_unittest.cc
+++ b/chrome/browser/google_apis/base_requests_server_unittest.cc
@@ -121,9 +121,7 @@ TEST_F(BaseOperationsServerTest, DownloadFileRequest_ValidFile) {
EXPECT_EQ(expected_contents, contents);
}
-// http://crbug.com/169588
-TEST_F(BaseOperationsServerTest,
- DISABLED_DownloadFileRequest_NonExistentFile) {
+TEST_F(BaseOperationsServerTest, DownloadFileRequest_NonExistentFile) {
GDataErrorCode result_code = GDATA_OTHER_ERROR;
base::FilePath temp_file;
DownloadFileRequest* operation = new DownloadFileRequest(
@@ -141,10 +139,6 @@ TEST_F(BaseOperationsServerTest,
operation_runner_->StartRequestWithRetry(operation);
base::MessageLoop::current()->Run();
- std::string contents;
- file_util::ReadFileToString(temp_file, &contents);
- file_util::Delete(temp_file, false);
-
EXPECT_EQ(HTTP_NOT_FOUND, result_code);
EXPECT_EQ(net::test_server::METHOD_GET, http_request_.method);
EXPECT_EQ("/files/chromeos/gdata/no-such-file.txt",
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698