Introduce StickyKeys settings item with behind flag.

Introduce StickyKeys settings item with behind flag.

I'd like to introduce sticky keys items into accessibility group.

BUG=229042
TEST=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213174

[Seigo Nonaka, 2013-06-12 05:16:49]

Hi Zach,

Could you start review this CL while back-end is still under reviewing.

Thank you.

[Zachary Kuznia, 2013-06-13 01:52:27]

https://codereview.chromium.org/16535004/diff/1/chrome/app/generated_resource...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/16535004/diff/1/chrome/app/generated_resource...
chrome/app/generated_resources.grd:7082: +          Enable sticky key
accessibility feature.
This isn't very descriptive.

[Seigo Nonaka, 2013-06-13 02:05:48]

https://codereview.chromium.org/16535004/diff/1/chrome/app/generated_resource...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/16535004/diff/1/chrome/app/generated_resource...
chrome/app/generated_resources.grd:7082: +          Enable sticky key
accessibility feature.
On 2013/06/13 01:52:27, Zachary Kuznia wrote:
> This isn't very descriptive.

Revised, how about this?

[Zachary Kuznia, 2013-06-13 22:47:03]

On 2013/06/13 02:05:48, Seigo Nonaka wrote:
>
https://codereview.chromium.org/16535004/diff/1/chrome/app/generated_resource...
> File chrome/app/generated_resources.grd (right):
> 
>
https://codereview.chromium.org/16535004/diff/1/chrome/app/generated_resource...
> chrome/app/generated_resources.grd:7082: +          Enable sticky key
> accessibility feature.
> On 2013/06/13 01:52:27, Zachary Kuznia wrote:
> > This isn't very descriptive.
> 
> Revised, how about this?

Try this, from wikipedia:
"StickyKeys allows the user to press and release a modifier key, such as Shift,
Ctrl, or Alt, and have it remain active until any other key is pressed."

[Seigo Nonaka, 2013-06-14 09:14:18]

On 2013/06/13 22:47:03, Zachary Kuznia wrote:
> On 2013/06/13 02:05:48, Seigo Nonaka wrote:
> >
>
https://codereview.chromium.org/16535004/diff/1/chrome/app/generated_resource...
> > File chrome/app/generated_resources.grd (right):
> > 
> >
>
https://codereview.chromium.org/16535004/diff/1/chrome/app/generated_resource...
> > chrome/app/generated_resources.grd:7082: +          Enable sticky key
> > accessibility feature.
> > On 2013/06/13 01:52:27, Zachary Kuznia wrote:
> > > This isn't very descriptive.
> > 
> > Revised, how about this?
> 
> Try this, from wikipedia:
> "StickyKeys allows the user to press and release a modifier key, such as
Shift,
> Ctrl, or Alt, and have it remain active until any other key is pressed."

Done, PTAL?

[Zachary Kuznia, 2013-06-14 18:28:30]

lgtm

[Seigo Nonaka, 2013-06-17 03:32:20]

Zach, thank you for your review!

Adding jhawkins@ as the owner of settings page.

Hi James, Could you take an owner review?

Thank you.

[James Hawkins, 2013-06-17 15:37:58]

Does this have UX approval to add a new setting?

[Seigo Nonaka, 2013-06-18 00:48:52]

On 2013/06/17 15:37:58, James Hawkins wrote:
> Does this have UX approval to add a new setting?

Not yet, kenjibaheux@ is now working on whole UX stuff including settings item.
Do we need UX approval even it is not visible by default?

Thank you.

[James Hawkins, 2013-06-18 00:52:39]

On 2013/06/18 00:48:52, Seigo Nonaka wrote:
> On 2013/06/17 15:37:58, James Hawkins wrote:
> > Does this have UX approval to add a new setting?
> 
> Not yet, kenjibaheux@ is now working on whole UX stuff including settings
item.
> Do we need UX approval even it is not visible by default?
> 
> Thank you.

I'd be more comfortable reviewing it w/ approval, so probably yes.

[Seigo Nonaka, 2013-06-18 00:56:26]

On 2013/06/18 00:52:39, James Hawkins wrote:
> On 2013/06/18 00:48:52, Seigo Nonaka wrote:
> > On 2013/06/17 15:37:58, James Hawkins wrote:
> > > Does this have UX approval to add a new setting?
> > 
> > Not yet, kenjibaheux@ is now working on whole UX stuff including settings
> item.
> > Do we need UX approval even it is not visible by default?
> > 
> > Thank you.
> 
> I'd be more comfortable reviewing it w/ approval, so probably yes.

Sure, I will ping you again after getting approval from UX.

Thank you.

[Seigo Nonaka, 2013-07-22 11:22:11]

Sorry for terribly late response.

I got approval from UX team, so could you start review again?

Thanks,
Seigo

[James Hawkins, 2013-07-22 15:37:48]

LGTM

https://codereview.chromium.org/16535004/diff/29001/chrome/common/chrome_swit...
File chrome/common/chrome_switches.cc (right):

https://codereview.chromium.org/16535004/diff/29001/chrome/common/chrome_swit...
chrome/common/chrome_switches.cc:670: // TODO(nona): Remove this switch and make
this as default.
Optional nit: This TODO is superfluous so consider removing it.

[Seigo Nonaka, 2013-07-23 07:10:02]

Thank you for your review! submitting...

https://codereview.chromium.org/16535004/diff/29001/chrome/common/chrome_swit...
File chrome/common/chrome_switches.cc (right):

https://codereview.chromium.org/16535004/diff/29001/chrome/common/chrome_swit...
chrome/common/chrome_switches.cc:670: // TODO(nona): Remove this switch and make
this as default.
On 2013/07/22 15:37:49, James Hawkins wrote:
> Optional nit: This TODO is superfluous so consider removing it.

Done.

[commit-bot: I haz the power, 2013-07-23 07:11:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nona@chromium.org/16535004/41001

[commit-bot: I haz the power, 2013-07-23 08:46:13]

Retried try job too often on mac_rel for step(s) sync_integration_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-07-23 18:10:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nona@chromium.org/16535004/41001

[commit-bot: I haz the power, 2013-07-23 18:34:40]

Change committed as 213174