Rename StorageMonitor Initialize function to EnsureInitialized for better understanding.

Rename StorageMonitor Initialize function to EnsureInitialized for better understanding.

BUG=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207808

[Haojian Wu, 2013-06-08 05:12:52]

This CL will replace the CL: https://codereview.chromium.org/16187002/

hongbo@ for initial review. 
vandebo@ ,Greg@ for EnsureInitialized function.

Thanks.

[Hongbo Min, 2013-06-08 05:16:06]

On 2013/06/08 05:12:52, Haojian Wu wrote:
> This CL will replace the CL: https://codereview.chromium.org/16187002/
> 
> hongbo@ for initial review. 
> vandebo@ ,Greg@ for EnsureInitialized function.
> 
> Thanks.

LGTM

[Haojian Wu, 2013-06-10 10:32:48]

ping vandebo@ ,Greg@

[Greg Billock, 2013-06-10 16:40:44]

On 2013/06/10 10:32:48, Haojian Wu wrote:
> ping vandebo@ ,Greg@

lgtm

[Haojian Wu, 2013-06-14 14:03:30]

ping vandebo@

[vandebo (ex-Chrome), 2013-06-17 14:44:59]

On 2013/06/14 14:03:30, Haojian Wu wrote:
> ping vandebo@

LGTM.  Picking one owner is sufficient for reviews.  The reviewer will add other
reviewers or require that you add other reviewers if there is an area they are
not familiar with.

[Haojian Wu, 2013-06-18 03:34:18]

On 2013/06/17 14:44:59, vandebo wrote:
> On 2013/06/14 14:03:30, Haojian Wu wrote:
> > ping vandebo@
> 
> LGTM.  Picking one owner is sufficient for reviews.  The reviewer will add
other
> reviewers or require that you add other reviewers if there is an area they are
> not familiar with.

Thanks for the tips.

[commit-bot: I haz the power, 2013-06-18 03:34:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/Hokein.Wu@gmail.com/16472007/1

[commit-bot: I haz the power, 2013-06-18 03:34:57]

Failed to apply patch for
chrome/browser/media_galleries/media_file_system_registry_unittest.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file
chrome/browser/media_galleries/media_file_system_registry_unittest.cc
  Hunk #1 FAILED at 747.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/media_galleries/media_file_system_registry_unittest.cc.rej

Patch:      
chrome/browser/media_galleries/media_file_system_registry_unittest.cc
Index: chrome/browser/media_galleries/media_file_system_registry_unittest.cc
diff --git
a/chrome/browser/media_galleries/media_file_system_registry_unittest.cc
b/chrome/browser/media_galleries/media_file_system_registry_unittest.cc
index
4118171250b65275eb37aa09bf095faa7c0c1907..b24c264a864d8b793e9618520a56c993b38a9df8
100644
--- a/chrome/browser/media_galleries/media_file_system_registry_unittest.cc
+++ b/chrome/browser/media_galleries/media_file_system_registry_unittest.cc
@@ -747,7 +747,7 @@ void MediaFileSystemRegistryTest::SetUp() {
   portable_device_watcher->set_use_dummy_mtp_storage_info(true);
   monitor_.reset(new test::TestStorageMonitorWin(
       mount_watcher, portable_device_watcher));
-  monitor_->Initialize(base::Bind(&base::DoNothing));
+  monitor_->EnsureInitialized(base::Bind(&base::DoNothing));
   // TODO(gbillock): Replace this with the correct event notification
   // on the storage monitor finishing the startup scan when that exists.
   base::RunLoop().RunUntilIdle();

[commit-bot: I haz the power, 2013-06-18 09:41:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/Hokein.Wu@gmail.com/16472007/8001

[commit-bot: I haz the power, 2013-06-18 10:05:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/Hokein.Wu@gmail.com/16472007/13001

[commit-bot: I haz the power, 2013-06-18 10:18:24]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[Haojian Wu, 2013-06-18 10:54:04]

@benwells, please review the change of media gallery api
files(media_galleries_api.cc and media_galleries_private_api.cc)
@Dan, please review the change of webui files(media_galleries_handler.cc)

Thanks.

[Dan Beam, 2013-06-20 00:35:31]

lgtm

https://chromiumcodereview.appspot.com/16472007/diff/13001/chrome/browser/sto...
File chrome/browser/storage_monitor/storage_monitor.h (right):

https://chromiumcodereview.appspot.com/16472007/diff/13001/chrome/browser/sto...
chrome/browser/storage_monitor/storage_monitor.h:75: // Initialize the storage
monitor. The provided callback, if non-null,
shouldn't this now say "Ensures that the storage monitor is initialized."?

[Haojian Wu, 2013-06-20 01:14:39]

On 2013/06/20 00:35:31, Dan Beam wrote:
> lgtm
> 
>
https://chromiumcodereview.appspot.com/16472007/diff/13001/chrome/browser/sto...
> File chrome/browser/storage_monitor/storage_monitor.h (right):
> 
>
https://chromiumcodereview.appspot.com/16472007/diff/13001/chrome/browser/sto...
> chrome/browser/storage_monitor/storage_monitor.h:75: // Initialize the storage
> monitor. The provided callback, if non-null,
> shouldn't this now say "Ensures that the storage monitor is initialized."?

Done.

[Haojian Wu, 2013-06-21 05:54:40]

ping benwells@.

[benwells, 2013-06-21 06:26:09]

On 2013/06/21 05:54:40, Haojian Wu wrote:
> ping benwells@.

lgtm, sorry for missing it earlier.

[commit-bot: I haz the power, 2013-06-21 07:14:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/Hokein.Wu@gmail.com/16472007/23001

[commit-bot: I haz the power, 2013-06-21 14:21:24]

Change committed as 207808