chrome/browser/storage_monitor/storage_monitor_unittest.cc - Issue 16472007: Rename StorageMonitor Initialize function to EnsureInitialized for better understanding.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/storage_monitor/storage_monitor_unittest.cc

Issue 16472007: Rename StorageMonitor Initialize function to EnsureInitialized for better understanding. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update comments Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/storage_monitor/storage_monitor.cc ('k') | chrome/browser/ui/webui/options/media_galleries_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/storage_monitor/storage_monitor_unittest.cc

diff --git a/chrome/browser/storage_monitor/storage_monitor_unittest.cc b/chrome/browser/storage_monitor/storage_monitor_unittest.cc

index 8acce30aeb189136e65077967ddfebf3b7ba6c3a..9be3a508d434b5a9dd9191358a2efc086af559cf 100644

--- a/chrome/browser/storage_monitor/storage_monitor_unittest.cc

+++ b/chrome/browser/storage_monitor/storage_monitor_unittest.cc

@@ -17,8 +17,8 @@ TEST(StorageMonitorTest, TestInitialize) {

EXPECT_FALSE(monitor.init_called_);

base::WaitableEvent event(false, false);

- monitor.Initialize(base::Bind(&base::WaitableEvent::Signal,

- base::Unretained(&event)));

+ monitor.EnsureInitialized(base::Bind(&base::WaitableEvent::Signal,

+ base::Unretained(&event)));

EXPECT_TRUE(monitor.init_called_);

EXPECT_FALSE(event.IsSignaled());

monitor.MarkInitialized();

« no previous file with comments | « chrome/browser/storage_monitor/storage_monitor.cc ('k') | chrome/browser/ui/webui/options/media_galleries_handler.cc » ('j') | no next file with comments »