Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 16469004: Use a direct include of strings headers in components/, part 1. (Closed)

Created:
7 years, 6 months ago by Avi (use Gerrit)
Modified:
7 years, 6 months ago
CC:
chromium-reviews, Raman Kakilate, benquan, tfarina, ahutter, browser-components-watch_chromium.org, dbeam+watch-autofill_chromium.org, Dane Wallinga, dyu1, Albert Bodenhamer, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

Use a direct include of strings headers in components/, part 1. BUG=247723 TEST=none TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205403

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -56 lines) Patch
M components/autofill/browser/address.h View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/browser/address.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/browser/address_field.h View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/browser/address_field.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/autofill/browser/address_field_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/browser/address_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/browser/android/auxiliary_profile_loader_android.h View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/browser/android/auxiliary_profile_unittest_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/browser/android/auxiliary_profiles_android.h View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/browser/android/auxiliary_profiles_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/autofill/browser/autocheckout/whitelist_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/browser/autocheckout_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/browser/autocomplete_history_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/browser/autocomplete_history_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/browser/autofill_country.h View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/browser/autofill_country.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/browser/autofill_country_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/browser/autofill_data_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/browser/autofill_download.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/browser/autofill_download_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/browser/autofill_external_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/browser/autofill_external_delegate_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/browser/autofill_field.h View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/browser/autofill_field_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/browser/autofill_ie_toolbar_import_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/browser/autofill_ie_toolbar_import_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/browser/autofill_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/browser/autofill_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/autofill/browser/autofill_manager_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/browser/autofill_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/autofill/browser/autofill_merge_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/browser/autofill_metrics_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/browser/autofill_popup_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/browser/autofill_profile.h View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/browser/autofill_profile.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/browser/autofill_profile_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/autofill/browser/autofill_regexes.h View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/browser/autofill_regexes.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/browser/autofill_regexes_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/browser/autofill_scanner.h View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/browser/autofill_type.h View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/browser/contact_info.h View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/browser/contact_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/browser/contact_info_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/browser/credit_card.h View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/browser/credit_card.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/autofill/browser/credit_card_field.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/autofill/browser/data_driven_test.h View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/browser/data_driven_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16469004/1
7 years, 6 months ago (2013-06-10 20:30:11 UTC) #1
commit-bot: I haz the power
7 years, 6 months ago (2013-06-11 04:17:11 UTC) #2
Message was sent while issue was closed. 
Change committed as 205403

Powered by Google App Engine
This is Rietveld 408576698