Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: extensions/common/url_pattern_set.h

Issue 16464004: Turn disallowed URL patterns such as <all_urls> for externally_connectable into (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: test that warnings also imply failure Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/install_warning.h ('k') | extensions/common/url_pattern_set.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/url_pattern_set.h
diff --git a/extensions/common/url_pattern_set.h b/extensions/common/url_pattern_set.h
index 0481d307c8001eff7a7d567b1c68d82d62ac815e..da6ad132db183433d726363f5d291b9e412e0158 100644
--- a/extensions/common/url_pattern_set.h
+++ b/extensions/common/url_pattern_set.h
@@ -72,6 +72,9 @@ class URLPatternSet {
// words, if every pattern in |set| is encompassed by a pattern in this.
bool Contains(const URLPatternSet& set) const;
+ // Returns true if any pattern in this set encompasses |pattern|.
+ bool ContainsPattern(const URLPattern& pattern) const;
+
// Test if the extent contains a URL.
bool MatchesURL(const GURL& url) const;
@@ -93,9 +96,6 @@ class URLPatternSet {
std::string* error);
private:
- // Returns true if any pattern in this set encompasses |pattern|.
- bool ContainsPattern(const URLPattern& pattern) const;
-
// The list of URL patterns that comprise the extent.
std::set<URLPattern> patterns_;
};
« no previous file with comments | « extensions/common/install_warning.h ('k') | extensions/common/url_pattern_set.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698