extensions/common/install_warning.h - Issue 16464004: Turn disallowed URL patterns such as <all_urls> for externally_connectable into

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/install_warning.h

Issue 16464004: Turn disallowed URL patterns such as <all_urls> for externally_connectable into (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: test that warnings also imply failure Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/manifest_handlers/externally_connectable_unittest.cc ('k') | extensions/common/url_pattern_set.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/install_warning.h

diff --git a/extensions/common/install_warning.h b/extensions/common/install_warning.h

index 6a2cb656b7c5c1ef7fccad812899bc9da5fa112f..fb3fccb29b6e6de7be242e83b0295aff933f9d24 100644

--- a/extensions/common/install_warning.h

+++ b/extensions/common/install_warning.h

@@ -17,6 +17,9 @@ struct InstallWarning {

FORMAT_TEXT,

FORMAT_HTML,

};

+ static InstallWarning Text(const std::string& message) {

+ return InstallWarning(FORMAT_TEXT, message);

+ }

InstallWarning(Format format, const std::string& message)

: format(format), message(message) {

}