Issue 16463002: Change ordering of Shell event handlers:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16463002: Change ordering of Shell event handlers: (Closed)

Created:
7 years, 6 months ago by varunjain

Modified:
7 years, 6 months ago

Reviewers:
oshima, sky

CC:
chromium-reviews, sadrul, dcheng, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Change ordering of Shell event handlers: crrev.com/14184010 made the DragDropController to be the first handler everytime a drag starts. That was done under the assumption that once we are in a drag drop session, no other handler needs to see the event. This assumption turned out to be false because the MouseCursorEventFilter needs to handle events even during a drag drop session so that the cursor can move across displays (causing the bug listed below). Hence, we make the DragDropController the second event handler while MouseCursorEvedntFilter becomes the first. BUG=244508 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204612

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -109 lines)			Patch
M	ash/drag_drop/drag_drop_controller.cc	View	2 chunks	+1 line, -7 lines	0 comments	Download
M	ash/drag_drop/drag_drop_controller_unittest.cc	View	1 chunk	+0 lines, -100 lines	0 comments	Download
M	ash/shell.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ash/shell_unittest.cc	View	3 chunks	+13 lines, -0 lines	0 comments	Download
M	ash/test/shell_test_api.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	ash/test/shell_test_api.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varunjain@chromium.org/16463002/1

7 years, 6 months ago (2013-06-06 15:43:46 UTC) #4

Message was sent while issue was closed.

Change committed as 204612

Expand Messages | Collapse Messages