Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Unified Diff: runtime/vm/source_report.h

Issue 1644793002: Replace intptr_t with TokenDescriptor (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/source_report.h
diff --git a/runtime/vm/source_report.h b/runtime/vm/source_report.h
index 9b03a232ffdea718482f756436d67bf76852cf89..98d6b8dba54c3d96e6fc7dbe37d3a1556df55b25 100644
--- a/runtime/vm/source_report.h
+++ b/runtime/vm/source_report.h
@@ -9,6 +9,7 @@
#include "vm/flags.h"
#include "vm/hash_map.h"
#include "vm/object.h"
+#include "vm/token_descriptor.h"
namespace dart {
@@ -38,11 +39,12 @@ class SourceReport {
// If script is null, then the report is generated for all scripts
// in the isolate.
void PrintJSON(JSONStream* js, const Script& script,
- intptr_t start_pos = -1, intptr_t end_pos = -1);
+ TokenDescriptor start_pos = TokenDescriptor::kNoSource,
+ TokenDescriptor end_pos = TokenDescriptor::kNoSource);
private:
void Init(Thread* thread, const Script* script,
- intptr_t start_pos, intptr_t end_pos);
+ TokenDescriptor start_pos, TokenDescriptor end_pos);
Thread* thread() const { return thread_; }
Zone* zone() const { return thread_->zone(); }
@@ -100,8 +102,8 @@ class SourceReport {
CompileMode compile_mode_;
Thread* thread_;
const Script* script_;
- intptr_t start_pos_;
- intptr_t end_pos_;
+ TokenDescriptor start_pos_;
+ TokenDescriptor end_pos_;
GrowableArray<ScriptTableEntry> script_table_entries_;
DirectChainedHashMap<ScriptTableTrait> script_table_;
intptr_t next_script_index_;

Powered by Google App Engine
This is Rietveld 408576698